<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>Sorry about this. I think if I'd finished the work to remove vtables from Value then it wouldn't be an issue, but I put that on hold due to performance concerns.</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">I can add back in a bunch of anchor functions where needed. Will just need to go through and find all the classes which need them.</div><div id="AppleMailSignature"><br></div><div id="AppleMailSignature">Pete<br><br>Sent from my iPhone</div><div><br>On Aug 7, 2015, at 10:32 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Aug 7, 2015 at 10:22 AM, Hans Wennborg via llvm-dev <span dir="ltr"><<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, Aug 6, 2015 at 12:04 PM, David Chisnall via llvm-dev<br>
<<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a>> wrote:<br>
> [Ooops, sent to the old list address by mistake]<br>
><br>
> On 30 Jul 2015, at 21:04, <a href="mailto:tom@stellard.net">tom@stellard.net</a> wrote:<br>
>><br>
>> For flags like -fno-rtti (are there others?) that are required in some cases<br>
>> (I think -fno-rtti is required only if you sub-class LLVM objects), I would propose<br>
>> adding a separate flag like --uses-rtti. This would give users more fine-grained<br>
>> control over which flags they use, and also would let them choose the correct<br>
>> flag since, for example, -fno-rtti is not understood by MSVC.<br>
><br>
> There appears to be a regression in LLVM 3.7, which means that you must compile with -fno-rtti if you include llvm’s Instructions.h. The issue is that a few of the classes (ICmpInst, GetElementPtrInst and PHINode) are now defined entirely in the header, so every compilation unit that includes the header will emit them. These classes all inherit from Instruction (indirectly via CmpInst in the case of ICmpInst) and so fail to link if compiled with -fno-rtti, because they can’t find the vtable for ICmpInst.<br>
<br>
</span>I looked at the file, and this didn't seem true (e.g.<br>
GetElementPtrInst::init is still out-of-line). But then I realized you<br>
mean virtual functions, so these classes no longer have a key<br>
function.<br>
<br>
This is probably Pete's r240588. I suppose we could add key functions<br>
to these classes (even if they're not used for anything). I'm not sure<br>
how we'd prevent this from regressing though :-/<br></blockquote><div><br>In theory the LLVM style guide mandates key functions for all dynamic classes (under the claim of build performance - avoiding duplicate vtable emission, etc). We've never strongly enforced it though - if we really wanted to, we could do so as Clang has a warning that triggers whenever a vtable is emitted weakly (which is what happens when there isn't a key function).<br><br>- David<br> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
- Hans<br>
<div class="HOEnZb"><div class="h5">_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org">llvm-dev@lists.llvm.org</a> <a href="http://llvm.cs.uiuc.edu" rel="noreferrer" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
</div></div></blockquote></div><br></div></div>
</div></blockquote></body></html>