<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Aug 5, 2015 at 2:20 AM, Andrei Serebro <span dir="ltr"><<a href="mailto:Andrei.Serebro@synopsys.com" target="_blank">Andrei.Serebro@synopsys.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal">Hi,<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Me and my supervisor are interested in improving llvm’s lit a little bit. Currently, there are few things, that seem to be not very convenient about the tool:<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Having several RUN commands in a failing test, it’s impossible to figure out, which of them actually caused the test to fail. We can output the number of the failing RUN line.</p></div></div></blockquote><div>Rather than just the number - we could probably print a caret diagnostic that quotes it? (what to do with multi-line run lines? I assume the caret diagnostic support doesn't support printing multiple lines)<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p><u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>It would be nice to distinguish test fails caused by some internal errors, e.g. segfaults and those which fail because of non 0 error code.</p></div></div></blockquote><div>Perhaps - but usually we print the output, which includes the crash stack trace, etc - so I've not personally had much confusion over which I'm looking at.<br><br>Has it been a problem for you? <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><div><p><u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Having support for different hardware extensions with no need to write custom test for each of them seems to be useful also. For example, it would be cool to have possibility to add some custom test options, which can be checked
during test initialization to avoid running unsupported by the hardware tests. <u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Also it would be nice to add more parameterization into RUN commands: for example, iterate over a predefined set of values, and run test with each of them as a parameter.<u></u><u></u></p>
<p><u></u><span style="font-family:Symbol"><span>·<span style="font:7.0pt "Times New Roman"">
</span></span></span><u></u>Add lit.cfg directory explicit setting: now it is always in the root, but maybe you want to use one file for many test suites, then you need to copy it to each suite root, which is not really convenient.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Main question is, are there some serious reasons why this was not implemented yet? If so, please describe them, for I’m really new one to llvm and particularly lit, and maybe don’t understand all the underneath problems of the suggestions
above.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Best regards,<u></u><u></u></p>
<p class="MsoNormal">Andrei Serebro<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:llvm-dev@lists.llvm.org" target="_blank">llvm-dev@lists.llvm.org</a> <a href="http://llvm.cs.uiuc.edu" rel="noreferrer" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev" rel="noreferrer" target="_blank">http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev</a><br>
<br></blockquote></div><br></div></div>