<div dir="ltr">Hi Eugene,<div><br></div><div>Sorry for the delayed reply. Custom relocations weren't something I had in mind when I designed Orc, so they raise some interesting design questions which I don't have good answers to yet. (E.g. The interface for the Orc layer concept assumes that there's a RuntimeDyld instance embedded at the bottom of the stack. That's why addModuleSet takes a MemoryManager and SymbolResolver. If there's no RuntimeDyld instance at the bottom of the stack, it's not obvious that the interface should require those).</div><div><div><div><br></div><div>For now I recommend just creating a local copy of the ObjectLinkingLayer and removing the call to resolveRelocations. I'll keep thinking about the best way to support this use case going forward.</div></div></div><div><br></div><div>Cheers,</div><div>Lang.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jul 22, 2015 at 11:51 PM, Eugene Rozenfeld <span dir="ltr"><<a href="mailto:Eugene.Rozenfeld@microsoft.com" target="_blank">Eugene.Rozenfeld@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Yes, I’m handling all internal and external relocations manually in NotifyLoadedFtor and I already verified that I get the behavior I need if I comment out the
call to resolveRelocations.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I would like to reuse ObjectLinkingLayer::addObjectSet (which eventually calls RuntimeDyld::loadObject), which has the right calls to the memory manager and also
RuntimeDyld::registerEHFrames. <u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I understand that resolveRelocations is normally the main job of ObjectLinkingLayer and as I said I can create my own ObjectLinkingLayer or something instead
of it that has these calls but it doesn’t feel right if all I need to reuse ObjectLinkingLayer is to avoid the resolveRelocations call.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Eugene<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Lang Hames [mailto:<a href="mailto:lhames@gmail.com" target="_blank">lhames@gmail.com</a>]
<br>
<b>Sent:</b> Wednesday, July 22, 2015 8:17 PM</span></p><div><div class="h5"><br>
<b>To:</b> Eugene Rozenfeld <<a href="mailto:Eugene.Rozenfeld@microsoft.com" target="_blank">Eugene.Rozenfeld@microsoft.com</a>><br>
<b>Cc:</b> <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: ORC and relocations<u></u><u></u></div></div><p></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">Hi Eugene,<u></u><u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<div>
<p class="MsoNormal">Skipping the call to resolveRelocations would disable many (if not all) internal relocations too. Is that the desired behavior?<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">At that point there's not much left for RuntimeDyld (or the ObjectLinkingLayer) to do. Would something like a NoopLinkingLayer be a workable solution?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Lang.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Wed, Jul 22, 2015 at 7:26 PM, Eugene Rozenfeld <<a href="mailto:Eugene.Rozenfeld@microsoft.com" target="_blank">Eugene.Rozenfeld@microsoft.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Hi Lang,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">It turns out I also need an ability to tell the object linking layer not to apply any relocations.
I need to skip <span style="background:yellow">this step</span> below.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">The only way I can see I can achieve that is by creating my own ObjectLinkingLayer that would duplicate
almost all of orc::ObjectLinkingLayer.</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">I’d like to avoid that. An alternative it to pass a flag to orc::ObjectLinkingLayer constructor and
orc::ObjectLinkingLayer::ConcreteLinkedObjectSet constructor</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">to indicate whether relocation resolution should be performed. Would you be ok with such a change?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Thanks,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Eugene</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:blue">template</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> <</span><span style="font-size:10.0pt;font-family:Consolas;color:blue">typename</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">NotifyLoadedFtor</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> = </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">DoNothingOnNotifyLoaded</span><span style="font-size:10.0pt;font-family:Consolas;color:black">></span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:blue">class</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">ObjectLinkingLayer</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> : </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">public</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">ObjectLinkingLayerBase</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:blue">private</span><span style="font-size:10.0pt;font-family:Consolas;color:black">:</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">template</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> <</span><span style="font-size:10.0pt;font-family:Consolas;color:blue">typename</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">MemoryManagerPtrT</span><span style="font-size:10.0pt;font-family:Consolas;color:black">, </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">typename</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">SymbolResolverPtrT</span><span style="font-size:10.0pt;font-family:Consolas;color:black">></span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">class</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">ConcreteLinkedObjectSet</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> : </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">public</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">LinkedObjectSet</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">public</span><span style="font-size:10.0pt;font-family:Consolas;color:black">:</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> ConcreteLinkedObjectSet(</span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">MemoryManagerPtrT</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:gray">MemMgr</span><span style="font-size:10.0pt;font-family:Consolas;color:black">,</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">SymbolResolverPtrT</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:gray">Resolver</span><span style="font-size:10.0pt;font-family:Consolas;color:black">)</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> : </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">LinkedObjectSet</span><span style="font-size:10.0pt;font-family:Consolas;color:black">(*</span><span style="font-size:10.0pt;font-family:Consolas;color:gray">MemMgr</span><span style="font-size:10.0pt;font-family:Consolas;color:black">, *</span><span style="font-size:10.0pt;font-family:Consolas;color:gray">Resolver</span><span style="font-size:10.0pt;font-family:Consolas;color:black">), MemMgr(std::move(</span><span style="font-size:10.0pt;font-family:Consolas;color:gray">MemMgr</span><span style="font-size:10.0pt;font-family:Consolas;color:black">)),</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> Resolver(std::move(</span><span style="font-size:10.0pt;font-family:Consolas;color:gray">Resolver</span><span style="font-size:10.0pt;font-family:Consolas;color:black">)) { }</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">void</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> Finalize() </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">override</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> State = </span><span style="font-size:10.0pt;font-family:Consolas;color:darkslategray">Finalizing</span><span style="font-size:10.0pt;font-family:Consolas;color:black">;</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> <span style="background:yellow">RTDyld->resolveRelocations();</span></span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> RTDyld->registerEHFrames();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> MemMgr->finalizeMemory();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> OwnedBuffers.clear();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> State = </span><span style="font-size:10.0pt;font-family:Consolas;color:darkslategray">Finalized</span><span style="font-size:10.0pt;font-family:Consolas;color:black">;</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri",sans-serif"> Lang Hames [mailto:<a href="mailto:lhames@gmail.com" target="_blank">lhames@gmail.com</a>]
<br>
<b>Sent:</b> Friday, July 3, 2015 6:36 PM<br>
<b>To:</b> Eugene Rozenfeld <<a href="mailto:Eugene.Rozenfeld@microsoft.com" target="_blank">Eugene.Rozenfeld@microsoft.com</a>><br>
<b>Cc:</b> <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: ORC and relocations</span><u></u><u></u></p>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">Hi Eugene,<u></u><u></u></p>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Sorry for the delayed reply. This looks good to me - I've applied it (along with some extra code to make it testable) in r241383.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Cheers,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Lang.<u></u><u></u></p>
</div>
</div>
<div>
<div>
<div>
<p class="MsoNormal"> <u></u><u></u></p>
<div>
<p class="MsoNormal">On Mon, Jun 29, 2015 at 7:31 PM, Eugene Rozenfeld <<a href="mailto:Eugene.Rozenfeld@microsoft.com" target="_blank">Eugene.Rozenfeld@microsoft.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Hi Lang,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Yes, I can return a non-zero marker value. Are you ok with this version?</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:blue">void</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">RuntimeDyldImpl</span><span style="font-size:10.0pt;font-family:Consolas;color:black">::resolveExternalSymbols() {</span><u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">while</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> (!ExternalSymbolRelocations.empty()) {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">StringMap</span><span style="font-size:10.0pt;font-family:Consolas;color:black"><</span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">RelocationList</span><span style="font-size:10.0pt;font-family:Consolas;color:black">>::</span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">iterator</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> i = ExternalSymbolRelocations.begin();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">StringRef</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> Name = i->first();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">if</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> (Name.size() == 0) {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// This is an absolute symbol, use an address of zero.</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#6f008a">DEBUG</span><span style="font-size:10.0pt;font-family:Consolas;color:black">(dbgs() << </span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"Resolving absolute relocations."</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> << </span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"\n"</span><span style="font-size:10.0pt;font-family:Consolas;color:black">);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">RelocationList</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> &Relocs = i->second;</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> resolveRelocationList(Relocs, 0);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> } </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">else</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">uint64_t</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> Addr = 0;</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">RTDyldSymbolTable</span><span style="font-size:10.0pt;font-family:Consolas;color:black">::</span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">const_iterator</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> Loc = GlobalSymbolTable.find(Name);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">if</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> (Loc == GlobalSymbolTable.end()) {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// This is an external symbol, try to get its address from the symbol</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// resolver.</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> Addr = Resolver.findSymbol(Name.data()).getAddress();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// The call to getSymbolAddress may have caused additional modules to</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// be loaded, which may have added new entries to the</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// ExternalSymbolRelocations map. Consquently, we need to update our</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// iterator. This is also why retrieval of the relocation list</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// associated with this symbol is deferred until below this point.</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// New entries may have been added to the relocation list.</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> i = ExternalSymbolRelocations.find(Name);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> } </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">else</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// We found the symbol in our global table. It was probably in a</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// Module that we loaded previously.</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">const</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">auto</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> &SymInfo = Loc->second;</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> Addr = getSectionLoadAddress(SymInfo.getSectionID()) +</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> SymInfo.getOffset();</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// FIXME: Implement error handling that doesn't kill the host program!</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue">if</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> (!Addr) {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> report_fatal_error(</span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"Program used external function '"</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> + Name +</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"' which could not be resolved!"</span><span style="font-size:10.0pt;font-family:Consolas;color:black">);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><u></u><u></u></p>
</div>
</div>
<pre style="background:white"><span style="font-family:Consolas;color:green"> <span style="background:yellow">// If Resolver returned UINT64_MAX, the client wants to handle this symbol</span></span><u></u><u></u></pre>
<pre style="background:white"><span style="font-family:Consolas;color:black;background:yellow"> </span><span style="font-family:Consolas;color:green;background:yellow">// manually and we shouldn't resolve its relocations.</span><u></u><u></u></pre>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:blue;background:yellow">if</span><span style="font-size:10.0pt;font-family:Consolas;color:black;background:yellow"> (Addr != </span><span style="font-size:10.0pt;font-family:Consolas;color:#6f008a;background:yellow">UINT64_MAX</span><span style="font-size:10.0pt;font-family:Consolas;color:black;background:yellow">)</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> {</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#6f008a">DEBUG</span><span style="font-size:10.0pt;font-family:Consolas;color:black">(dbgs() << </span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"Resolving relocations Name: "</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> << Name << </span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"\t"</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> << format(</span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"0x%lx"</span><span style="font-size:10.0pt;font-family:Consolas;color:black">, Addr) << </span><span style="font-size:10.0pt;font-family:Consolas;color:#a31515">"\n"</span><span style="font-size:10.0pt;font-family:Consolas;color:black">);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// This list may have been updated when we called getSymbolAddress, so</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:green">// don't change this code to get the list earlier.</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><span style="font-size:10.0pt;font-family:Consolas;color:#2b91af">RelocationList</span><span style="font-size:10.0pt;font-family:Consolas;color:black"> &Relocs = i->second;</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> resolveRelocationList(Relocs, Addr);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> </span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> ExternalSymbolRelocations.erase(i);</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black"> }</span><u></u><u></u></p>
<p class="MsoNormal" style="background:white">
<span style="font-size:10.0pt;font-family:Consolas;color:black">}</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Thanks,</span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1f497d">Eugene</span><u></u><u></u></p>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</blockquote></div><br></div>