<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Firstly, thanks for the detailed update on this...<br class=""><div><blockquote type="cite" class=""><div class="">On Jul 13, 2015, at 7:59 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com" class="">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><span style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px; float: none; display: inline !important;" class="">Ok, those are all the thoughts I have currently about AA, and where I'm headed. This should hopefully provide context for some of the upcoming patches.</span></div></blockquote></div>‘Headed’ w.r.t. to the new pass manager specifically, or AA in both old and new pass managers? ‘Upcoming patches’ makes it sound like this is coming soon so will likely be before the new PM is the only PM.<div class=""><br class=""></div><div class="">TBH i’m worried about the surface area we have to debug for correctness/performance issues when it comes time to adopt the new pass manager.</div><div class=""><br class=""></div><div class="">The new pass manager by design is going to lead to different behavior. Analyses will be preserved and invalidated in different orders from old to new PMs leading to differences in behavior of transform passes. Bugs will be found in transforms themselves as a result of the new PM ultimately (indirectly) giving them different code. All of this is going to take time to debug and block adoption of the new PM.</div><div class=""><br class=""></div><div class="">I’d like to see us try get the new PM enabled before increasing the surface area any more. Removing the bad AA updating code was fine as we still have the same AA updating behavior between old/new (i.e., no AA updating). But I think adding new AA API should be done either in both PMs or neither (for now). For one thing, we can’t have enough confidence that the code is working correctly if it only works in the new PM which isn’t yet being exposed to as much code as the old PM. Unit tests can only do so much as we can have confidence that the AA API is good with a unit test, but its harder to have confidence that a transform is calling it correctly without lots of code going through the transform pass.</div><div class=""><br class=""></div><div class="">Bugs in transforms related to AA updating will likely be extremely subtle and its better to have a blame list as short as possible. That can only happen if the AA code is running on the bots or else we may not catch it until the new PM is adopted.</div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Pete</div></body></html>