<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hey Salem,<div class=""><br class=""></div><div class="">Any chance you’ve had time to take a look at this?</div><div class=""><br class=""></div><div class="">If you prefer, I can prepare a patch with the change i’d like to make and we can see if you are happy with it.</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">Pete<br class=""><div><blockquote type="cite" class=""><div class="">On Jun 9, 2015, at 4:09 PM, Pete Cooper <<a href="mailto:peter_cooper@apple.com" class="">peter_cooper@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="Content-Type" content="text/html charset=utf-8" class=""><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi all<div class=""><br class=""></div><div class="">Saleem, in 2014 you added the .thumb_set test case. I’ve found a difference in behaviour of .thumb_set compared to .set. I was hoping to resolve this difference as it will allow me to reapply r239440.</div><div class=""><br class=""></div><div class="">The issue i’m seeing is that we define an alpha function, then beta function, then assign alpha to beta. But given that beta has already been defined, this would mean we are redefining it at the point of the .thumb_set:</div><div class=""><br class=""></div><div class=""><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>.text</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>.thumb</div><div class=""><br class=""></div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>.thumb_set alias_defined_data, bedazzle</div><div class=""><br class=""></div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>.type alpha,%function</div><div class="">alpha:</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>nop</div><div class=""><br class=""></div><div class=""> .type beta,%function</div><div class="">beta:</div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>bkpt</div><div class=""><br class=""></div><div class=""><span class="Apple-tab-span" style="white-space:pre"> </span>.thumb_set beta, alpha</div></div><div class=""><br class=""></div><div class="">The above code currently passes. However, if I change .thumb_set to .set then I get</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><b class="">../test/MC/ARM/thumb_set.s:60:13: </b><span style="font-variant-ligatures: no-common-ligatures; color: #c33720" class=""><b class="">error: </b></span><b class="">redefinition of 'beta'</b></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""> .set beta, alpha</div></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">I would like to make .thumb_set throw the same error here as I believe that is how it should behave in this case.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Please let me know if you are ok with this, or some other approach. I’m unfamiliar with it so its possible that what i’ve found isn’t a bug at all but just how we want it to behave.</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Cheers,</div><div style="margin: 0px; font-size: 11px; font-family: Menlo;" class="">Pete</div></div></div></blockquote></div><br class=""></div></body></html>