<div dir="rtl"><div dir="ltr">You can also look for people patching CFI- or X86- related code.</div></div><div class="gmail_extra"><br><div class="gmail_quote"><div dir="ltr">2015-06-05 13:11 GMT+03:00 Neil Henning <span dir="ltr"><<a href="mailto:llvm@duskborn.com" target="_blank">llvm@duskborn.com</a>></span>:</div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
Look at the CODE_OWNERS.txt file, find the places your patch touches
and who owns them, add those people to the review. At least that's
what I've been told previously when submitting patches.<br>
<br>
-Neil.<div><div class="h5"><br>
<br>
<div>On 05/06/15 10:54, Alex wrote:<br>
</div>
</div></div><blockquote type="cite"><div><div class="h5">
<div dir="ltr">Dear LLVM devs,
<div><br>
</div>
<div>I just submitted a patch: <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10149&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=nZZqzbxhY7-xAfSiCDcR2N_iD2VxcU1KAZOU2nmF-50&s=cp7ZvsQqW1U9EYlIGQEAvE8Nmp1zXoM8rF3cezzN7IM&e=" target="_blank">http://reviews.llvm.org/D10149</a>.
However, Phabricator is warning me that "this revision needs
review, but there are no reviewers specified".</div>
<div><br>
</div>
<div>How should I determine who the reviewers should be?</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Alex Dowad</div>
</div>
<br>
<fieldset></fieldset>
<br>
</div></div><pre>_______________________________________________
LLVM Developers mailing list
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a>
</pre>
</blockquote>
<br>
</div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><br></div>