<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hi Manuel,<div class=""><br class=""></div><div class="">I like Phabricator for code review much much more than emails. Let me know how I can help (I’m not afraid of PHP).<div class=""><br class=""></div><div class="">— </div><div class="">Mehdi</div><div class=""><br class=""><div class=""><br class=""></div><div class=""><br class=""><div><blockquote type="cite" class=""><div class="">On May 27, 2015, at 3:12 AM, Manuel Klimek <<a href="mailto:klimek@google.com" class="">klimek@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Quick update from IRC chat:<br class="">Justin (and anybody else who wants to) is going to file bugs against our phab workflow on the llvm-bugtracker until we get a component for it. Help with keeping our phab instance merged and implementing features we need would be highly appreciated (let me know if you'd like to help with PHP hacking ;)</div><br class=""><div class="gmail_quote">On Wed, May 27, 2015 at 8:54 AM Justin Bogner <<a href="mailto:mail@justinbogner.com" class="">mail@justinbogner.com</a>> wrote:<br class=""><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Moving this to llvmdev - it needs a bit of a wider audience.<br class="">
<br class="">
There are several issues with phabricator, and in the current state of<br class="">
things there's a huge amount of confusion on how to even report<br class="">
problems, let alone try to resolve them.<br class="">
<br class="">
Recently I started a thread about empty emails, was directed to the<br class="">
phabricator project's bug tracker, and told there that LLVM has<br class="">
customized phabricator so there's nothing they (phab) can do. Soon<br class="">
after, the message I'm replying to below was sent to llvm-admin, and it<br class="">
was pointed out that they don't maintain phab, so there's nothing *they*<br class="">
can do:<br class="">
<br class="">
Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank" class="">chandlerc@google.com</a>> writes:<br class="">
> On Tue, May 26, 2015 at 1:31 PM Tanya Lattner <<a href="mailto:tonic@nondot.org" target="_blank" class="">tonic@nondot.org</a>> wrote:<br class="">
>> On Apr 30, 2015, at 4:25 PM, Matthias Braun <<a href="mailto:matze@braunis.de" target="_blank" class="">matze@braunis.de</a>> wrote:<br class="">
>>> This happens to me as well from time to time. I wonder if there is a<br class="">
>>> way to have phabricator add llvm-commits to CC as soon as<br class="">
>>> "repository llvm" or "project llvm" is selected. Or maybe revisions<br class="">
>>> with an empty subscribers field could be rejected.<br class="">
>><br class="">
>> llvm-admin doesn't administrate the phabricator. You need to contact:<br class="">
>> Manuel Klimek or Chandler Carruth.<br class="">
><br class="">
> This has been discussed before. If you look at the prior discussions on<br class="">
> llvmdev about phabricator you should find lots of references to it.<br class="">
><br class="">
> I don't want to repeat the entire discussion but the essence is "sure, it<br class="">
> could be done, but someone must write the code to do it". The code is posted<br class="">
> where you can get at it, we can even put it in an LLVM repository if that<br class="">
> helps, but so far none have stepped up to write the code to make this happen.<br class="">
> I donated hardware to get this whole thing started for a year, and Manuel did<br class="">
> the much more time consuming work to get it up to the point it is currently<br class="">
> at, but I don't think he has a lot more time to devote to it.<br class="">
<br class="">
I appreciate the effort that you (Chandler) and Manuel have put into<br class="">
this, but I find this answer a bit lacking in important details.<br class="">
<br class="">
Where is the code posted? Where is the documentation about that? The<br class="">
docs at <a href="https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_docs_Phabricator.html&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=qHj0853NIJxgsizaAYOr0vhQPWpAgRpQgywGYHT2CRU&s=JS0eDDtJFMTO7BpI-Nv4KZZhMUgYpbLSUFmycYIKjuo&e=" target="_blank" class="">http://llvm.org/docs/Phabricator.html</a> don't tell me anything<br class="">
more than "Please let us know whether you like it and what could be<br class="">
improved!".<br class="">
<br class="">
Most importantly, where can I file bugs about LLVM's phabricator<br class="">
instance?<br class="">
<br class="">
> Fundamentally, we need folks in the community to contribute if they have<br class="">
> significant problems with the tools.<br class="">
<br class="">
Personally, as a reviewer, I find phabricator reviews strictly worse<br class="">
than sending a patch to the llvm-commits list. Off the top of my head,<br class="">
with phab:<br class="">
<br class="">
- The patch doesn't always show up on the mailing list,<br class="">
- Replies to review comments and the patch that accompanies them come in<br class="">
different emails,<br class="">
- Several emails show up in your inbox with nothing but a link, and no<br class="">
indication why they were sent,<br class="">
- Comments and responses to comments sometimes show up twice - once from<br class="">
the person who says them and another time from phab,<br class="">
- Patches are often (but not always) duplicated - both inline *and*<br class="">
attached. This is bizarre, useless, and confuses tools like git-am.<br class="">
<br class="">
With an email it's trivial to read the diff or to apply the patch to an<br class="">
LLVM checkout to look at in more detail, including building it or<br class="">
looking at the result in a text editor.<br class="">
<br class="">
I realize that quite a few people find the web interface helpful, so<br class="">
I've refrained from asking people to post patches directly rather than<br class="">
using phab so far, but that *would* solve my problems with the tool. We<br class="">
at least need some clear information on how to file bugs and where to<br class="">
look if we want to try to fix the problems ourselves.<br class="">
</blockquote></div>
_______________________________________________<br class="">LLVM Developers mailing list<br class=""><a href="mailto:LLVMdev@cs.uiuc.edu" class="">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" class="">http://llvm.cs.uiuc.edu</a><br class=""><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" class="">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br class=""></div></blockquote></div><br class=""></div></div></div></body></html>