<div dir="ltr">Hi Dave, Per,<div><br></div><div>Dave - The issue Eric raised was with chapters 7 and 8. I've fixed that in 235541.<div><br></div><div>Per - It's not obvious to my why Chapter 4 should need RTTI. What error are you seeing?</div></div><div><br></div><div>Cheers,</div><div>Lang.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 21, 2015 at 3:11 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Apr 21, 2015 at 3:07 PM, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:<br>
> No progress since Charlie last looked at it.<br>
<br>
</span>Sorry, I meant to refer to the issue Per Mildner mentioned regarding<br>
the tutorials not building due to RTTI - which I recall discussing<br>
with you & Eric, but don't know what came of it.<br>
<div class="HOEnZb"><div class="h5"><br>
> As Per suggested, it may be<br>
> worth adding an explicit #error, or at least a comment, noting that the<br>
> later examples are broken.<br>
><br>
> Going forward, I see three options:<br>
><br>
> (1) Remove the old tutorials entirely, and encourage people to check out the<br>
> MCJIT and Orc versions.<br>
> (2) Build an Orc-based stack that approximates the behavior of the Old JIT<br>
> (which the old tutorials assume).<br>
> (3) Rewrite the old tutorial to natively use the new APIs.<br>
><br>
> I much prefer the third option. The first option misses out on a lot of<br>
> language/API discussion that's contained in the later chapters of the old<br>
> tutorials. The second option replicates a JIT stack that wouldn't be useful<br>
> for most clients.<br>
><br>
> If we were going to pursue option three, the simple JIT from the Orc/initial<br>
> tutorial seems like a good starting point to re-write the old tutorials.<br>
> Then we'd have an interesting bifurcation part way through the tutorial<br>
> series: Go one way and add new language features on top of the simple JIT,<br>
> or go another and add features to the JIT while keeping the language steady.<br>
> Cross-polination of the two branches (new JIT features + new language<br>
> features) could be handled in future tutorials, or left as an exercise for<br>
> the reader.<br>
><br>
> The tricky part, as usual, is finding the time to do this.<br>
> Volunteers/patches welcome. :)<br>
><br>
> Cheers,<br>
> Lang.<br>
><br>
><br>
> On Tue, Apr 21, 2015 at 9:16 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:<br>
>><br>
>><br>
>><br>
>> On Tue, Apr 21, 2015 at 7:26 AM, Per Mildner <<a href="mailto:Per.Mildner@sics.se">Per.Mildner@sics.se</a>> wrote:<br>
>>><br>
>>> Charlie Turner <charlesturner7c5 <at> <a href="http://gmail.com" target="_blank">gmail.com</a>> writes:<br>
>>><br>
>>> > I was planning on committing these changes with the corresponding<br>
>>> > changes to the Kaleidoscope tutorial walk-through. Might be a bit of a<br>
>>> > surprise to have no explanation of what MCJITHelper and friends is<br>
>>> > doing.<br>
>>> ><br>
>>> > I'll try and make time to prepare some patches along these lines, as<br>
>>> > well as updating future chapters with the same fix.<br>
>>> ><br>
>>> > Thanks for taking a look :)<br>
>>><br>
>>><br>
>>> Any progress on fixing the tutorial?<br>
>>><br>
>>> I am about to dive into LLVM and after some hair-pulling found that the<br>
>>> Kaleidoscope tutorials (from part 5 onwards), are broken.<br>
>>><br>
>>> Obviously this is not a good first impression.<br>
>>><br>
>>> (even a note in the source code, #error "currently does not work", would<br>
>>> be<br>
>>> a huge improvement, since it would avoid a lot of wasted time for the<br>
>>> beginner.)<br>
>>><br>
>>> PS. On OS X 10.8.5, the compile command for part 4 of the tutorial needs<br>
>>> -fno-rtti, presumably because the code now inherits from a LLVM class.<br>
>><br>
>><br>
>> Lang - recall what the state is here?<br>
>><br>
>>><br>
>>><br>
>>> Regards,<br>
>>><br>
>>> Per Mildner<br>
>>><br>
>>><br>
>>> _______________________________________________<br>
>>> LLVM Developers mailing list<br>
>>> <a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
>><br>
>><br>
><br>
</div></div></blockquote></div><br></div>