<div dir="ltr">+dexonsmith<div><br></div><div><br></div><div>-- Sean Silva</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Apr 6, 2015 at 11:20 AM, Robinson, Paul <span dir="ltr"><<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank">Paul_Robinson@playstation.sony.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Aha, okay. I had noticed that the column-info hack went away. So the distinct-ness implies the scope implicit in the inlined call, which later on will be
turned into the explicit inlined_subroutine entry. That seems… indirect.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I have to say, the LangRef page's words about "merge based on content" is not really to the point. It's like saying the purpose of a street-corner STOP sign
is to make you stop. That's the mechanism it uses, but it's not why the sign is there. It would be great if somebody would clarify what distinct-ness is actually good for.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="14c8ff97bf90237a__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> David Blaikie [mailto:<a href="mailto:dblaikie@gmail.com" target="_blank">dblaikie@gmail.com</a>]
<br>
<b>Sent:</b> Monday, April 06, 2015 10:38 AM<br>
<b>To:</b> Robinson, Paul<br>
<b>Cc:</b> LLVM Developers Mailing List (<a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a>)<br>
<b>Subject:</b> Re: [LLVMdev] "distinct" metadata nodes are ...?<u></u><u></u></span></p>
</div>
</div><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, Apr 6, 2015 at 10:26 AM, Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com" target="_blank">Paul_Robinson@playstation.sony.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">I'm encountering a merge issue whose root cause has to do with "distinct"<br>
metadata nodes. I see that distinct-ness is an intentional concept, but<br>
the explanation in the LLVM Language Reference is not very enlightening.<br>
<br>
distinct nodes are useful when nodes shouldn't be merged based on<br>
their content.<br>
<br>
The notion of "merged" metadata is not discussed elsewhere on the page,<br>
except for Objective-C garbage collection; I'm looking at debug location<br>
metadata, so that's not relevant.<br>
<br>
I understand that distinct-ness was invented as a replacement for a<br>
self-reference hack, but that just begs the question. Why is this a<br>
useful concept? What is it used for? Why shouldn't certain nodes be<br>
merged based on their content?<br>
<br>
My specific issue has to do with inlined-at chains. If I have<br>
return inlined_func() + 1;<br>
the inlined-at chain for inlined_func() [and whatever else is inlined<br>
into inlined_func()] terminates in a node that is 'distinct' from the<br>
node for the calling statement, even though they describe the same<br>
source location. This didn't used to be a problem, chasing the chain<br>
ended up with something that compared equal to the calling statement's<br>
source location.<u></u><u></u></p>
<div>
<p class="MsoNormal"><br>
<a href="http://llvm.org/viewvc/llvm-project?rev=226736&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=226736&view=rev</a> is the change that caused this & has some context on why it's necessary.<br>
<br>
The issue is that the scope change of debuglocs is how we build scopes, including inline scopes (DW_TAG_inlined_subroutine). If the call site locations aren't uniqued, then two calls from the same line to the same function would have the same location and thus
be the same scope - so we'd only have one DW_TAG_inlined_subroutine, instead of two.<br>
<br>
Clang worked around this for a while by putting column info on call sites to help give them unique call sites, but this was insufficient (the two calls could've come from within a macro, in which case they'd be attributed to the same line/column again).<br>
<br>
- David<br>
<u></u><u></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Thanks,<br>
--paulr<br>
<br>
<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><u></u><u></u></p>
</blockquote>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div>
</div></div></div>
</div>
</div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><br></div>