<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
So would anyone object to me trying to find a resolution for this?
The easiest way would be that explicit subdirectories in the
LLVMBuild.txt are always picked up, but we could have a way to scan
the folders in lib/Target, and any folder can be added if it was
declared in the experimental build option (or something to that
effect).<br>
<br>
-Neil.<br>
<br>
<div class="moz-cite-prefix">On 09/03/15 17:22, Eric Christopher
wrote:<br>
</div>
<blockquote
cite="mid:CALehDX6t5TXyhKMDHsja9q8ef6XN8gJMzcsJqnrxu52pnDUCiA@mail.gmail.com"
type="cite">
<div dir="ltr">Mmm.. true. Explicit dependencies are both nice and
annoying. We'd need to mention it somewhere basically.
<div><br>
</div>
<div>-eric<br>
<br>
<div class="gmail_quote">On Mon, Mar 9, 2015 at 10:19 AM Anton
Korobeynikov <<a moz-do-not-send="true"
href="mailto:anton@korobeynikov.info">anton@korobeynikov.info</a>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I
believe we'd need LLVMBuild.txt even in autoconf build -
for bunch<br>
of autogenerated stuff, e.g. list of all asmprinters /
asmparsers /<br>
InitializeAllTargetInfos, etc., since targets are not
autoregistered<br>
anymore.<br>
<br>
On Mon, Mar 9, 2015 at 7:20 PM, Eric Christopher <<a
moz-do-not-send="true" href="mailto:echristo@gmail.com"
target="_blank">echristo@gmail.com</a>> wrote:<br>
> Hi Neil,<br>
><br>
> Weird, I'd think the cmake build should probably do
something similar to the<br>
> autoconf build if possible and just have
subdirectories equal to the targets<br>
> to build. I'm not sure if this is possible etc...
could try some setting<br>
> etc.<br>
><br>
> -eric<br>
><br>
> On Mon, Mar 9, 2015 at 9:11 AM Neil Henning <<a
moz-do-not-send="true" href="mailto:llvm@duskborn.com"
target="_blank">llvm@duskborn.com</a>> wrote:<br>
>><br>
>> Hey all,<br>
>><br>
>> Quick query on out of tree target support - at
present I can drop a folder<br>
>> Foo into <llvm>/lib/Target/Foo and use the
CMake option<br>
>> LLVM_EXPERIMENTAL_TARGETS_TO_BUILD to pick up my
target. The issue is that I<br>
>> still need to patch the one LLVMBuild.txt file in
<llvm>/lib/Target with;<br>
>><br>
>> iff --git a/lib/Target/LLVMBuild.txt
b/lib/Target/LLVMBuild.txt<br>
>> index 4112046..6e42cbe 100644<br>
>> --- a/lib/Target/LLVMBuild.txt<br>
>> +++ b/lib/Target/LLVMBuild.txt<br>
>> @@ -16,7 +16,7 @@<br>
>><br>
>> ;===------------------------------------------------------------------------===;<br>
>><br>
>> [common]<br>
>> -subdirectories = ARM AArch64 BPF CppBackend
Hexagon MSP430 NVPTX Mips<br>
>> PowerPC R600 Sparc SystemZ X86 XCore<br>
>> +subdirectories = ARM AArch64 BPF CppBackend
Hexagon MSP430 NVPTX Mips<br>
>> PowerPC R600 Sparc SystemZ X86 XCore Foo<br>
>><br>
>> ; This is a special group whose required
libraries are extended (by<br>
>> llvm-build)<br>
>> ; with the best execution engine (the native
JIT, if available, or the<br>
>><br>
>> To include my target in the LLVM build, and this
allows me to specify<br>
>> -march=foo and it will call into my code
correctly.<br>
>><br>
>> Am I missing something - or is this patch
definitely required?<br>
>><br>
>> If the patch is required - does anyone have any
suggestions/ideas how I<br>
>> could add support to either LLVMBuild or the
specific LLVMBuild.txt file so<br>
>> that it would pick up my new Target?<br>
>><br>
>> I understand that my patch is tiny and relatively
easy to maintain (it<br>
>> will basically always merge well) - but it still
irks me having to keep a<br>
>> patch where it probably isn't required!<br>
>><br>
>> Cheers,<br>
>> -Neil.<br>
>> _______________________________________________<br>
>> LLVM Developers mailing list<br>
>> <a moz-do-not-send="true"
href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a>
<a moz-do-not-send="true"
href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
>> <a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
><br>
><br>
> _______________________________________________<br>
> LLVM Developers mailing list<br>
> <a moz-do-not-send="true"
href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a>
<a moz-do-not-send="true"
href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
> <a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
><br>
<br>
<br>
<br>
--<br>
With best regards, Anton Korobeynikov<br>
Faculty of Mathematics and Mechanics, Saint Petersburg
State University<br>
</blockquote>
</div>
</div>
</div>
</blockquote>
<br>
</body>
</html>