<div dir="ltr">I can't apply this diff. Can you send the patch as an attachment?</div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Feb 19, 2015 at 10:38 AM, Ralph Campbell <span dir="ltr"><<a href="mailto:ralph.campbell@broadcom.com" target="_blank">ralph.campbell@broadcom.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal">I was reading various documents in the llvm/docs/ directory and found a few minor typos.<u></u><u></u></p>
<p class="MsoNormal">I don’t have write access so if someone could apply these for me, that would be great.<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">---<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Index: docs/LangRef.rst<u></u><u></u></p>
<p class="MsoNormal">===================================================================<u></u><u></u></p>
<p class="MsoNormal">--- docs/LangRef.rst (revision 228410)<u></u><u></u></p>
<p class="MsoNormal">+++ docs/LangRef.rst (working copy)<u></u><u></u></p>
<p class="MsoNormal">@@ -368,7 +368,7 @@<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> The idea behind this convention is to support calls to runtime functions<u></u><u></u></p>
<p class="MsoNormal"> that have a hot path and a cold path. The hot path is usually a small piece<u></u><u></u></p>
<p class="MsoNormal">- of code that doesn't many registers. The cold path might need to call out to<u></u><u></u></p>
<p class="MsoNormal">+ of code that doesn't use many registers. The cold path might need to call out to<u></u><u></u></p>
<p class="MsoNormal"> another function and therefore only needs to preserve the caller-saved<u></u><u></u></p>
<p class="MsoNormal"> registers, which haven't already been saved by the caller. The<u></u><u></u></p>
<p class="MsoNormal"> `PreserveMost` calling convention is very similar to the `cold` calling<u></u><u></u></p>
<p class="MsoNormal">@@ -521,7 +521,7 @@<u></u><u></u></p>
<p class="MsoNormal">Global variables define regions of memory allocated at compilation time<u></u><u></u></p>
<p class="MsoNormal">instead of run-time.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">-Global variables definitions must be initialized.<u></u><u></u></p>
<p class="MsoNormal">+Global variable definitions must be initialized.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> Global variables in other translation units can also be declared, in which<u></u><u></u></p>
<p class="MsoNormal">case they don't have an initializer.<u></u><u></u></p>
<p class="MsoNormal">@@ -666,7 +666,7 @@<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> LLVM allows an explicit section to be specified for functions. If the<u></u><u></u></p>
<p class="MsoNormal">target supports it, it will emit functions to the section specified.<u></u><u></u></p>
<p class="MsoNormal">-Additionally, the function can placed in a COMDAT.<u></u><u></u></p>
<p class="MsoNormal">+Additionally, the function can be placed in a COMDAT.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> An explicit alignment may be specified for a function. If not present,<u></u><u></u></p>
<p class="MsoNormal">or if the alignment is set to zero, the alignment of the function is set<u></u><u></u></p>
<p class="MsoNormal">@@ -674,7 +674,7 @@<u></u><u></u></p>
<p class="MsoNormal">is specified, the function is forced to have at least that much<u></u><u></u></p>
<p class="MsoNormal">alignment. All alignments must be a power of 2.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">-If the ``unnamed_addr`` attribute is given, the address is know to not<u></u><u></u></p>
<p class="MsoNormal">+If the ``unnamed_addr`` attribute is given, the address is known to not<u></u><u></u></p>
<p class="MsoNormal">be significant and two identical functions can be merged.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> Syntax::<u></u><u></u></p>
<p class="MsoNormal">@@ -716,7 +716,7 @@<u></u><u></u></p>
<p class="MsoNormal">``linkonce_odr``, ``weak_odr``, ``external``. Note that some system linkers<u></u><u></u></p>
<p class="MsoNormal">might not correctly handle dropping a weak symbol that is aliased.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">-Alias that are not ``unnamed_addr`` are guaranteed to have the same address as<u></u><u></u></p>
<p class="MsoNormal">+Aliases that are not ``unnamed_addr`` are guaranteed to have the same address as<u></u><u></u></p>
<p class="MsoNormal">the aliasee expression. ``unnamed_addr`` ones are only guaranteed to point<u></u><u></u></p>
<p class="MsoNormal">to the same content.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">@@ -1779,7 +1779,7 @@<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> LLVM IR floating-point binary ops (:ref:`fadd <i_fadd>`,<u></u><u></u></p>
<p class="MsoNormal">:ref:`fsub <i_fsub>`, :ref:`fmul <i_fmul>`, :ref:`fdiv <i_fdiv>`,<u></u><u></u></p>
<p class="MsoNormal">-:ref:`frem <i_frem>`) have the following flags that can set to enable<u></u><u></u></p>
<p class="MsoNormal">+:ref:`frem <i_frem>`) have the following flags that can be set to enable<u></u><u></u></p>
<p class="MsoNormal">otherwise unsafe floating point operations<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal"> ``nnan``<u></u><u></u></p>
<p class="MsoNormal">Index: docs/CodeGenerator.rst<u></u><u></u></p>
<p class="MsoNormal">===================================================================<u></u><u></u></p>
<p class="MsoNormal">--- docs/CodeGenerator.rst (revision 227370)<u></u><u></u></p>
<p class="MsoNormal">+++ docs/CodeGenerator.rst (working copy)<u></u><u></u></p>
<p class="MsoNormal">@@ -1340,7 +1340,7 @@<u></u><u></u></p>
<p class="MsoNormal">If the indirect strategy is used, after all the virtual registers have been<u></u><u></u></p>
<p class="MsoNormal">mapped to physical registers or stack slots, it is necessary to use a spiller<u></u><u></u></p>
<p class="MsoNormal">object to place load and store instructions in the code. Every virtual that has<u></u><u></u></p>
<p class="MsoNormal">-been mapped to a stack slot will be stored to memory after been defined and will<u></u><u></u></p>
<p class="MsoNormal">+been mapped to a stack slot will be stored to memory after being defined and will<u></u><u></u></p>
<p class="MsoNormal">be loaded before being used. The implementation of the spiller tries to recycle<u></u><u></u></p>
<p class="MsoNormal">load/store instructions, avoiding unnecessary instructions. For an example of<u></u><u></u></p>
<p class="MsoNormal">how to invoke the spiller, see ``RegAllocLinearScan::runOnMachineFunction`` in<u></u><u></u></p>
<p class="MsoNormal">@@ -1353,7 +1353,7 @@<u></u><u></u></p>
<p class="MsoNormal">instructions are three address instructions. That is, each instruction is<u></u><u></u></p>
<p class="MsoNormal">expected to define at most one register, and to use at most two registers.<u></u><u></u></p>
<p class="MsoNormal">However, some architectures use two address instructions. In this case, the<u></u><u></u></p>
<p class="MsoNormal">-defined register is also one of the used register. For instance, an instruction<u></u><u></u></p>
<p class="MsoNormal">+defined register is also one of the used registers. For instance, an instruction<u></u><u></u></p>
<p class="MsoNormal">such as ``ADD %EAX, %EBX``, in X86 is actually equivalent to ``%EAX = %EAX +<u></u><u></u></p>
<p class="MsoNormal">%EBX``.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">@@ -1578,7 +1578,7 @@<u></u><u></u></p>
<p class="MsoNormal"> correspond to. The MCInsts that are generated by this are fed into the<u></u><u></u></p>
<p class="MsoNormal"> instruction printer or the encoder.<u></u><u></u></p>
<p class="MsoNormal"><u></u><u></u></p>
<p class="MsoNormal">-Finally, at your choosing, you can also implement an subclass of MCCodeEmitter<u></u><u></u></p>
<p class="MsoNormal">+Finally, at your choosing, you can also implement a subclass of MCCodeEmitter<u></u><u></u></p>
<p class="MsoNormal">which lowers MCInst's into machine code bytes and relocations. This is<u></u><u></u></p>
<p class="MsoNormal">important if you want to support direct .o file emission, or would like to<u></u><u></u></p>
<p class="MsoNormal">implement an assembler for your target.<u></u><u></u></p>
</div>
</div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><br></div>