Hi Paul,<div><br></div><div>I'm not sure I see any reason to wait until after 3.6. More changes are incoming and it's better to get them over with sooner rather than spread out the pain.</div><div><br></div><div>Thanks!</div><div><br></div><div>-eric<br><br><div class="gmail_quote">On Mon Jan 12 2015 at 9:52:48 PM Robinson, Paul <<a href="mailto:Paul_Robinson@playstation.sony.com">Paul_Robinson@playstation.sony.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Would you mind terribly waiting a week, until after 3.6 is forked?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">We're barely caught up with the last big metadata syntax change.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">--paulr<u></u><u></u></span></p>
<p class="MsoNormal"><a name="msg-f:1490161100158492937__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> <a href="mailto:llvmdev-bounces@cs.uiuc.edu" target="_blank">llvmdev-bounces@cs.uiuc.edu</a> [mailto:<a href="mailto:llvmdev-bounces@cs.uiuc.edu" target="_blank">llvmdev-bounces@cs.uiuc.edu</a>]
<b>On Behalf Of </b>Duncan P. N. Exon Smith<br>
<b>Sent:</b> Monday, January 12, 2015 8:30 PM<br>
<b>To:</b> LLVM Developers Mailing List<br>
<b>Subject:</b> [LLVMdev] [RFC] First-class debug info IR: MDLocation (redux)<u></u><u></u></span></p>
</div>
</div></div></div></div><div lang="EN-US" link="blue" vlink="purple"><div><div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt">After splitting `Metadata` apart from `Value`, I'm finally back to the<br>
first step [1] of representing debug info more directly in IR [2]:<br>
`MDLocation`.<br>
<br>
[1]: <a href="http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-October/078173.html" target="_blank">
http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-October/078173.html</a><br>
"First-class debug info IR: MDLocation"<br>
[2]: <a href="http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-October/077715.html" target="_blank">
http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-October/077715.html</a><br>
"Less memory and greater maintainability for debug info IR"<br>
<br>
I've attached two patches which are both essentially commit-ready (just<br>
missing LangRef update, AFAIK), although they just add the class and<br>
assembly/bitcode support. Once it's in tree, I'll move it into place<br>
underneath `DebugLoc` and `DILocation` and update the world of<br>
testcases, publish a script, and so forth.<br>
<br>
Assembly syntax<br>
===============<br>
<br>
I've changed the assembly syntax a little since my previous proposal<br>
[1], but I kept the fundamentals the same:<br>
<br>
- Fields use key/value pairs and can be specified in any order.<br>
- No types (unless you're referencing a `Value`).<br>
- Some fields are required (in this case, 'scope:').<br>
- Unspecified fields get sane default values.<br>
<br>
Old syntax:<br>
<br>
!6 = metadata MDLocation(line: 43, column: 7, scope: !4)<br>
<br>
Now it's:<br>
<br>
!6 = !MDLocation(line: 43, column: 7, scope: !4)<br>
<br>
Here's why:<br>
<br>
- Dropped 'metadata' since `Metadata` is now typeless \O/.<br>
<br>
- Added a '!' since it makes the parser simpler (no changes to the<br>
lexer, since we can unambiguously reuse the `MetadataVar` token),<br>
and follows the rule that "All metadata are identified in syntax by<br>
a[n] exclamation point" [3]. (If people are opposed to the extra<br>
'!' I can update this sentence instead, but it seems like a handy<br>
mnemonic to maintain.)<br>
<br>
[3]: <a href="http://llvm.org/docs/LangRef.html#metadata" target="_blank">http://llvm.org/docs/LangRef.html#metadata</a><br>
<br>
Where this is heading<br>
=====================<br>
<br>
See my previous post [1] ;).<u></u><u></u></span></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt">_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">
http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><u></u><u></u></span></p>
</div>
</div>
</div></div></div>
______________________________<u></u>_________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvmdev</a><br>
</blockquote></div></div>