<div dir="ltr">+eric, who introduced the test in r<span style="font-size:13px">222076. </span><div><span style="font-size:13px">Eric, how does the test fail under asan? </span></div><div><span style="font-size:13px">Do you expect a leak report? </span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jan 6, 2015 at 3:16 PM, Sanjoy Das <span dir="ltr"><<a href="mailto:sanjoy@playingwithpointers.com" target="_blank">sanjoy@playingwithpointers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">My change 225282 broke an asan test [1], but by the time I got around<br>
to trying to revert it, I noticed that the test had started passing.<br>
Moreover, it seems to have been "fixed" by 225291 which at least does<br>
not seem related to the breakage directly.<br>
<br>
I'm puzzled now -- is the failing asan test flaky?  Should I still<br>
revert 225282?<br>
<br>
Thank you for your time!<br>
<br>
[1]: <a href="http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-asan/builds/98/steps/test.libcxx/logs/stdio" target="_blank">http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-asan/builds/98/steps/test.libcxx/logs/stdio</a><br>
<br>
-- Sanjoy<br>
_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a>         <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
</blockquote></div><br></div>