<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Oct 6, 2014 at 2:47 PM, Eric Christopher <span dir="ltr"><<a href="mailto:echristo@google.com" target="_blank">echristo@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Mon, Oct 6, 2014 at 12:54 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>It is unfortunate that we are using a different coding scheme for LLD than LLVM, but I'm leaning toward the view that switching to LLVM style will cost too much if it means we are going to lose virtually all commit history. A patch to switch to LLVM style would rename all local and member variables, so it would touch all the lines. Diff is not powerful enough to trace the history beyond variable renaming. svn blame would become useless.</div><div><br></div></div></blockquote><div><br></div></span><div>You can have svn/git ignore whitespace changes for blame FWIW. I don't know how this will work for general reformatting though :\</div><div><br></div><div>Do you have a feel?</div></div></div></div></blockquote><div><br></div><div>I don't think there's an option to make git/svn-diff to ignore case change and leading underscore removal. Is there?</div><div><br></div><div>Ideally maybe we should write a better diff tool that can ignore variable renaming. Because we can make clang-rename, it's doable at least.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div></div></div></div></blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><span class="HOEnZb"><font color="#888888"><div></div><div>-eric </div></font></span><span class=""><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div></div><div>I have no strong opinion on this. If many other LLD developers really want to make this happen, I can bear with that. It doesn't feel very productive thing to do to me, though.</div></div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 5, 2014 at 2:26 PM, Tim Northover <span dir="ltr"><<a href="mailto:t.p.northover@gmail.com" target="_blank">t.p.northover@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>> So with that in mind, I would like to ask, would it be possible to consider<br>
> switching to LLVM style for lld?<br>
<br>
</span>One particular feature of lld's current style is particularly dodgy:<br>
starting member variables with '_' makes undefined behaviour very easy<br>
to introduce (if the first real char is upper case; there's already<br>
plenty of examples).<br>
<br>
It's one of the more innocuous forms of UB, but still bad form for an<br>
LLVM project. If even we can't get it right...<br>
<br>
Cheers.<br>
<span><font color="#888888"><br>
Tim.<br>
</font></span><div><div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
</div></div></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></span></div><br></div></div>
</blockquote></div><br></div></div>