<div dir="ltr">I think we should format code using LLVM coding conventions, much easier to follow and maintain. I think lldb also could consider moving towards one coding convention style.</div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, Oct 5, 2014 at 1:46 PM, Chandler Carruth-2 [via LLVM] <span dir="ltr"><<a href="/user/SendEmail.jtp?type=node&node=73138&i=0" target="_top" rel="nofollow" link="external">[hidden email]</a>></span> wrote:<br><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote"><span class="">On Sun, Oct 5, 2014 at 9:37 AM, Renato Golin <span dir="ltr"><<a href="http://user/SendEmail.jtp?type=node&node=73136&i=0" rel="nofollow" link="external" target="_blank">[hidden email]</a>></span> wrote:<br><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' style="border-left:2px solid #cccccc;padding:0 1em" class="gmail_quote"><span>On 5 October 2014 07:19, Saleem Abdulrasool <<a href="http://user/SendEmail.jtp?type=node&node=73136&i=1" rel="nofollow" link="external" target="_blank">[hidden email]</a>> wrote:<br>
> So with that in mind, I would like to ask, would it be possible to consider<br>
> switching to LLVM style for lld?<br>
<br>
</span>We don't usually enforce code styles on side projects because it<br>
doesn't make sense to do so.</blockquote><div><br></div></span><div>This is not completely accurate. Both LLD and LLDB were given specific exemptions from the coding standards, but Clang wasn't and I wouldn't expect a new subproject to *necessarily* get such an exemption. It might, it might not.</div><div><br></div><div>I consider the current state with both LLD and LLDB a bug rather than a feature because it creates pointless and non-trivial disruption for developers to move between LLVM, Clang, LLD, and LLDB. You can argue that coding standards are like fashion, but *changing* coding standards is a much more pragmatic and real concern. At least one important point of LLVM's standards (in my mind and I suspect other developers' minds) is to drive consistency both within projects and across projects.</div><span class=""><div> </div><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' style="border-left:2px solid #cccccc;padding:0 1em" class="gmail_quote">Code style changes with time. If the majority of lld developers agree<br>
with you that the current style is bad and needs to be changed (to a<br>
more LLVM-ish style),</blockquote><div><br></div></span><div>Figuring out whether most LLD devs want to switch seems like the point of the email?</div><span class=""><div> </div><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' style="border-left:2px solid #cccccc;padding:0 1em" class="gmail_quote"> than future commits should move lld's style<br>
towards that. Not by adding new styles to one line inside an old<br>
function, but by deprecating style when you deprecate code, and<br>
creating style when you create code.<br></blockquote><div><br></div></span><div>That is one option. But the developers of LLD may be willing to more aggressively convert. We should let them speak for themselves rather than hypothesizing here.</div><span class=""><div> </div><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' style="border-left:2px solid #cccccc;padding:0 1em" class="gmail_quote">
<br>
It's also very likely that, by the time you have converted all old<br>
code with new style, the preferred style will have changed, and you'll<br>
want to do it all over again. To avoid that pointless race against<br>
nothing, we tend to keep the style that was in the original<br>
file/function and not mind much.<br></blockquote><div><br></div></span><div>This has not been my experience in any part of the LLVM project. The coding standards are extremely stable these days.</div></div></div></div><span class="">
<br>_______________________________________________
<br>LLVM Developers mailing list
<br><a href="http://user/SendEmail.jtp?type=node&node=73136&i=2" rel="nofollow" link="external" target="_blank">[hidden email]</a> <a href="http://llvm.cs.uiuc.edu" rel="nofollow" link="external" target="_blank">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" rel="nofollow" link="external" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br>
<br>
<hr noshade size="1" color="#cccccc">
</span><div style="color:#444;font:12px tahoma,geneva,helvetica,arial,sans-serif"><span class="">
<div style="font-weight:bold">If you reply to this email, your message will be added to the discussion below:</div>
</span><a href="http://llvm.1065342.n5.nabble.com/lld-coding-style-tp73133p73136.html" target="_blank" rel="nofollow" link="external">http://llvm.1065342.n5.nabble.com/lld-coding-style-tp73133p73136.html</a>
</div><div class="HOEnZb"><div class="h5">
<div style="color:#666;font:11px tahoma,geneva,helvetica,arial,sans-serif;margin-top:.4em;line-height:1.5em">
To start a new topic under LLVM - Dev, email <a href="/user/SendEmail.jtp?type=node&node=73138&i=1" target="_top" rel="nofollow" link="external">[hidden email]</a> <br>
To unsubscribe from LLVM - Dev, <a href="" target="_blank" rel="nofollow" link="external">click here</a>.<br>
<a href="http://llvm.1065342.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml" rel="nofollow" style="font:9px serif" target="_blank" link="external">NAML</a>
</div></div></div></blockquote></div><br></div>
<br/><hr align="left" width="300" />
View this message in context: <a href="http://llvm.1065342.n5.nabble.com/lld-coding-style-tp73133p73138.html">Re: lld coding style</a><br/>
Sent from the <a href="http://llvm.1065342.n5.nabble.com/LLVM-Dev-f3.html">LLVM - Dev mailing list archive</a> at Nabble.com.<br/>