<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">On Sep 20, 2014, at 11:37 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:<br><div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Sep 20, 2014 at 11:26 AM, Dan Liew <span dir="ltr"><<a href="mailto:dan@su-root.co.uk" target="_blank">dan@su-root.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 18 September 2014 16:59, Reid Kleckner <<a href="mailto:rnk@google.com">rnk@google.com</a>> wrote:<br>
> I also want to point out that there is prior art for bundling these types of<br>
> single-source-file utility libraries in lib/Support. We have MD5.cpp,<br>
> ConvertUTF.cpp, and reg*.c implementing various bits of functionality.<br>
> Adding a miniz.c doesn't seem like that big of a deal.<br>
<br>
</span>I should of taken a look at miniz first! It is pretty small. I guess provided<br>
<br>
1.The library code is properly namespaced to prevent symbol clashes<br>
for LLVM clients that already use miniz directly or indirectly.<br>
2. Someone takes ownership over this code inside LLVM<br>
<br>
then this is probably fine. Sorry I have a bit of knee-jerk reaction<br>
where I hear about embedding libraries because it's caused me problems<br>
in the past.<br>
<br>
Would the aim be to use miniz as a fallback if libz isn't available or<br>
we want always use miniz?<br>
<br>
I'll submit the patch that started to be developed in this thread to<br>
llvm-commits for review anyway as it might be useful to have it in<br>
trunk.</blockquote></div><br>I would much rather have consistent and predictable behavior by using the bundled source code on every platform.</div></div></blockquote><br></div><div>Is your answer the same if we're talking about an asm version of zlib that's faster than the compiled version? Because that's a thing.</div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-family: Monaco; "><font face="Monaco" size="1" style="font: normal normal normal 9px/normal Monaco; ">-----------------------------------------</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-family: Monaco; "><font face="Monaco" size="1" style="font: normal normal normal 9px/normal Monaco; ">Alex Rosenberg</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-family: Monaco; "><font face="Monaco" size="1" style="font: normal normal normal 9px/normal Monaco; ">Manager, Platform Architecture</font></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font-family: Monaco; "><font face="Monaco" size="1" style="font: normal normal normal 9px/normal Monaco; ">Sony Computer Entertainment America, Inc.</font></div></span>
</div>
<br></body></html>