<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Aug 8, 2014, at 18:35 , Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">On 25 July 2014 17:57, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:<br><blockquote type="cite">To be clear, I don't think we need both; I'd like for us to drop one of<br>them. I just want to make sure that that the final state, post merge, works<br>well on all of our platforms. :)<br></blockquote><br>Cool. The attached patch removes TempDir. It passes all tests, but the<br>OS X case looks a bit suspicious. I first implemented it by given<br>priority to confstr, but we depend on the env variables taking<br>priority for testing the crash report. Is there some way to change<br>what confstr returns?<br><br>Should we just add a -cc1 command line option for use in<br>test/Driver/crash-report.c?<br></blockquote></div><br><div>Thanks for doing this, Rafael!</div><div><br></div><div>It looks like OS X always has TMPDIR set these days (to the value of _CS_DARWIN_USER_TEMP_DIR), so I think we should just go with TMPDIR if it's set and non-empty, and then fall back to confstr. However, we should <i>not</i> be using TMPDIR if ErasedOnReboot is false (i.e. if we'd prefer _CS_DARWIN_USER_CACHE_DIR). Unfortunately there's no canonical environment variable for that.</div><div><br></div><div>CCing Greg to see if that makes sense.</div><div>Jordan</div></body></html>