<div dir="ltr">I updated <a href="http://reviews.llvm.org/D4717">http://reviews.llvm.org/D4717</a> and also wrote an __probestack implementation:  <a href="https://github.com/Zoxc/compiler-rt/compare/llvm-mirror:master...stprobe">https://github.com/Zoxc/compiler-rt/compare/llvm-mirror:master...stprobe</a><div>
<br></div><div>Which instruction would be the preferable one to probe with? I used OR since that's what GCC/libgcc does, but I don't see why that would be better than a write.<br><div class="gmail_extra"><br><br><div class="gmail_quote">
On Tue, Aug 5, 2014 at 7:34 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div class="">On Tue, Aug 5, 2014 at 8:53 AM, John Kåre Alsaker <span dir="ltr"><<a href="mailto:john.mailinglists@gmail.com" target="_blank">john.mailinglists@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">Would the __probestack functions be a suitable addition to compiler-rt? Does it already have __chkstk or is that provided by something else on Windows? I noticed that libgcc implemented them in cygwin.S. </div>

</blockquote><div><br></div></div><div>It seems reasonable to put them in compiler-rt/lib/builtins.</div><div><br></div><div>I don't think anyone is currently using compiler-rt's builtins on Windows, so it doesn't have __chkstk. Typically that is provided by the Cygwin, MinGW, or MSVC C runtime.</div>

</div></div></div>
</blockquote></div><br></div></div></div>