<meta http-equiv="content-type" content="text/html; charset=utf-8"><div>Sure, I agree.</div><div><br>On Aug 1, 2014, at 13:10, "Daniel Stewart [via LLVM]" <<a href="/user/SendEmail.jtp?type=node&node=70983&i=0" target="_top" rel="nofollow" link="external">[hidden email]</a>> wrote:<br><br></div><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' type="cite"><div>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii"><meta name="Generator" content="Microsoft Word 15 (filtered medium)"><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--><div class="WordSection1"><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Shankar,<o:p></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> I’ll try to add test cases before it gets committed. But I’ll start the process to get it up on Phabricator to at least allow people to give feedback. Since I fully believe there will be comments I have to address anyway, I’ll be able to add test cases at the same time. <o:p></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Daniel<o:p></o:p></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p><div><div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"><p class="MsoNormal"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:windowtext"> Shankar Easwaran [mailto:<a href="/user/SendEmail.jtp?type=node&node=70979&i=0" target="_top" rel="nofollow" link="external">[hidden email]</a>] <br><b>Sent:</b> Friday, August 01, 2014 1:40 PM<br><b>To:</b> Daniel Stewart; <a href="/user/SendEmail.jtp?type=node&node=70979&i=1" target="_top" rel="nofollow" link="external">[hidden email]</a><br><b>Subject:</b> Re: [LLVMdev] [lld] ELF/AArch64 support in lld<o:p></o:p></span></p></div></div><p class="MsoNormal"><o:p> </o:p></p><div><p class="MsoNormal">Hi Daniel,<br><br>We would need a testcase before you commit the change to the repository.<br><br>This is to make sure future patches dont break functionality already addressed.<br><br>Shankar Easwaran<br><br>On 7/31/2014 8:51 PM, Daniel Stewart wrote:<o:p></o:p></p></div><blockquote style='border-left:2px solid #CCCCCC;padding:0 1em' style="border-left:2px solid #CCCCCC;padding:0 1em"><pre>I've been implementing ELF/AArch64 support for lld. I can now successfully<o:p></o:p></pre><pre>link and run a simple "Hello World" app for both dynamic and static linking.<o:p></o:p></pre><pre>I'd like to upstream this implementation, but wanted to get feedback on how<o:p></o:p></pre><pre>people might like to see it. Would people rather see the whole thing in one<o:p></o:p></pre><pre>shot, each file individually or somehow break it down even farther? The<o:p></o:p></pre><pre>implementation obviously requires all the files due to their interplay, so<o:p></o:p></pre><pre>I'm not sure how only some files could be committed without the others. <o:p></o:p></pre><pre><o:p> </o:p></pre><pre> <o:p></o:p></pre><pre><o:p> </o:p></pre><pre>I don't yet have tests for everything; is it possible to upstream now or<o:p></o:p></pre><pre>wait until I have a complete test suite in place as well? <o:p></o:p></pre><pre><o:p> </o:p></pre><pre> <o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Trying to get feedback now to make the process as smooth as possible.<o:p></o:p></pre><pre><o:p> </o:p></pre><pre> <o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Thanks,<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Daniel<o:p></o:p></pre><pre><o:p> </o:p></pre><pre> <o:p></o:p></pre><pre><o:p> </o:p></pre><pre>--<o:p></o:p></pre><pre><o:p> </o:p></pre><pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by<o:p></o:p></pre><pre>The Linux Foundation<o:p></o:p></pre><pre><o:p> </o:p></pre><pre> <o:p></o:p></pre><pre><o:p> </o:p></pre><pre><o:p> </o:p></pre><p class="MsoNormal"><br><br><br><o:p></o:p></p><pre>_______________________________________________<o:p></o:p></pre><pre>LLVM Developers mailing list<o:p></o:p></pre><pre><a href="/user/SendEmail.jtp?type=node&node=70979&i=2" target="_top" rel="nofollow" link="external">[hidden email]</a> <a href="http://llvm.cs.uiuc.edu" target="_top" rel="nofollow" link="external">http://llvm.cs.uiuc.edu</a><o:p></o:p></pre><pre><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_top" rel="nofollow" link="external">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><o:p></o:p></pre></blockquote><p class="MsoNormal"><br><br><br><o:p></o:p></p><pre>-- <o:p></o:p></pre><pre>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<o:p></o:p></pre></div><br>_______________________________________________
<br>LLVM Developers mailing list
<br><a href="/user/SendEmail.jtp?type=node&node=70979&i=3" target="_top" rel="nofollow" link="external">[hidden email]</a> <a href="http://llvm.cs.uiuc.edu" target="_top" rel="nofollow" link="external">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_top" rel="nofollow" link="external">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br>
<br>
<hr noshade="noshade" size="1" color="#cccccc">
<div style="color:#444; font: 12px tahoma,geneva,helvetica,arial,sans-serif;">
<div style="font-weight:bold">If you reply to this email, your message will be added to the discussion below:</div>
<a href="http://llvm.1065342.n5.nabble.com/lld-ELF-AArch64-support-in-lld-tp70951p70979.html" target="_top" rel="nofollow" link="external">http://llvm.1065342.n5.nabble.com/lld-ELF-AArch64-support-in-lld-tp70951p70979.html</a>
</div>
<div style="color:#666; font: 11px tahoma,geneva,helvetica,arial,sans-serif;margin-top:.4em;line-height:1.5em">
To start a new topic under LLVM - Dev, email <a href="/user/SendEmail.jtp?type=node&node=70983&i=1" target="_top" rel="nofollow" link="external">[hidden email]</a> <br>
To unsubscribe from LLVM - Dev, <a href="" target="_top" rel="nofollow" link="external">click here</a>.<br>
<a href="http://llvm.1065342.n5.nabble.com/template/NamlServlet.jtp?macro=macro_viewer&id=instant_html%21nabble%3Aemail.naml&base=nabble.naml.namespaces.BasicNamespace-nabble.view.web.template.NabbleNamespace-nabble.view.web.template.NodeNamespace&breadcrumbs=notify_subscribers%21nabble%3Aemail.naml-instant_emails%21nabble%3Aemail.naml-send_instant_email%21nabble%3Aemail.naml" rel="nofollow" style="font:9px serif" target="_top" link="external">NAML</a>
</div></div></blockquote>
<br/><hr align="left" width="300" />
View this message in context: <a href="http://llvm.1065342.n5.nabble.com/lld-ELF-AArch64-support-in-lld-tp70951p70983.html">Re: [lld] ELF/AArch64 support in lld</a><br/>
Sent from the <a href="http://llvm.1065342.n5.nabble.com/LLVM-Dev-f3.html">LLVM - Dev mailing list archive</a> at Nabble.com.<br/>