<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div>LGTM<br><br>Sent from my iPhone</div><div><br>On Jul 28, 2014, at 11:55, Sean Silva <<a href="mailto:chisophugis@gmail.com">chisophugis@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 28, 2014 at 6:21 AM, Simon Atanasyan <span dir="ltr"><<a href="mailto:simon@atanasyan.com" target="_blank">simon@atanasyan.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Let's suppose that MCLinker folks are here already - I am a committer<br>
of this project :).<br></blockquote><div><br></div><div>Doesn't seem like a problem then.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Maybe I did not formulate my suggestion correctly. When I offer to<br>
"install" the yaml2obj and obj2yaml utilities I mean result of the<br>
"make install" command only. I do not suggest to include this<br>
utilities into any distributed binary packages. To be clear I attached<br>
the patch with suggested changes.<br></blockquote><div><br></div><div>I don't think that patch would hurt. I'd like a second opinion from Rafael though.</div><div><br></div><div>-- Sean Silva</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Mon, Jul 28, 2014 at 3:07 AM, Sean Silva <<a href="mailto:chisophugis@gmail.com">chisophugis@gmail.com</a>> wrote:<br>
> I think that installing these tools and having them used by third-party<br>
> projects are separate questions.<br>
><br>
> AFAIK, currently these tools are considered purely internal testing tools,<br>
> so we don't want external projects relying on them. Anyway, I personally<br>
> can't think of any project other than MCLinker for which it would make sense<br>
> to depend on these tools, so better to just have the MCLinker folks get<br>
> involved upstream.<br>
><br>
> As to installing the tools, I'm sure that many of the tools that get<br>
> installed currently are testing tools as well, so I don't see the harm of<br>
> installing these tools (besides possibly bloating packages, which should<br>
> probably be evaluated). Personally I don't think these tools are very useful<br>
> outside of their testing role so I wouldn't bother installing them.<br>
><br>
> -- Sean Silva<br>
><br>
> On Sun, Jul 27, 2014 at 8:57 AM, Simon Atanasyan <<a href="mailto:simon@atanasyan.com">simon@atanasyan.com</a>><br>
> wrote:<br>
>><br>
>> Now the yaml2obj and obj2yaml utilities used in LLVM and LLD projects<br>
>> tests only and not installed by the "make install" command. I think<br>
>> they might be also useful in third-party projects like MCLinker. I<br>
>> suggest to move these utilities into the "tools" category and install<br>
>> them together with other LLVM tools.<br>
>><br>
>> Any objections or comments?<br>
<br>
--<br>
Simon Atanasyan<br>
</div></div></blockquote></div><br></div></div>
</div></blockquote></body></html>