<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='color:#1F497D'>Yes, the fix is </span>set_source_file_properties(<arm .S files> PROPERTIES LANGUAGE C)?</p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I will try using your patch for running builtins tests in my local set up.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Thanks<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>--Sumanth G<o:p></o:p></span></p><div><div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>On Tue, Jul 8, 2014 at 2:44 PM, sgundapa <<a href="mailto:sgundapa@codeaurora.org" target="_blank">sgundapa@codeaurora.org</a>> wrote:<o:p></o:p></p><p class=MsoNormal>No. CMake has different way of treating the .S files<br>Refer to <a href="http://www.cmake.org/Wiki/CMake/Assembler" target="_blank">http://www.cmake.org/Wiki/CMake/Assembler</a><br><br>I have a patch which will make CMake treat the .S files as source files.<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Let me guess, you should just call set_source_file_properties(<arm .S files> PROPERTIES LANGUAGE C)?<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal>But, how I can run the unit tests. I see from compiler-rt/test/CMakeLists.txt<br><br># BlocksRuntime and builtins testsuites are not yet ported to lit.<br># add_subdirectory(BlocksRuntime)<br># add_subdirectory(builtins)<br><br>How do you run the unit tests for builtins?<o:p></o:p></p></blockquote><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Well, there is <a href="http://reviews.llvm.org/D4251">http://reviews.llvm.org/D4251</a> which adds support for running the tests under CTest, but it's not yet reviewed.<o:p></o:p></p></div><div><p class=MsoNormal>There's also a "test/builtins/Unit/test" script, but I doubt it will run out of the box.<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p class=MsoNormal><br><br>--Sumanth G<o:p></o:p></p><div><div><p class=MsoNormal style='margin-bottom:12.0pt'>-----Original Message-----<br>From: Renato Golin [mailto:<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>]<br>Sent: Tuesday, July 08, 2014 12:19 PM<br>To: Alexey Samsonov<br>Cc: sgundapa; LLVM Dev<br>Subject: Re: [LLVMdev] [compiler-rt] CMake bug in building ARM builtins library<br><br>On 8 July 2014 19:47, Alexey Samsonov <<a href="mailto:vonosmas@gmail.com">vonosmas@gmail.com</a>> wrote:<br>> compiler-rt/lib/builtins/arm/*.S files are listed in arm_SOURCES<br>> variable, and therefore should make it into the builtins static<br>> library on ARM. Don't they?<br><br>I assume so... But I'm not an expert in CMake.<o:p></o:p></p></div></div></blockquote></div><p class=MsoNormal><br><br clear=all><o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>-- <o:p></o:p></p><div><p class=MsoNormal>Alexey Samsonov<br><a href="mailto:vonosmas@gmail.com" target="_blank">vonosmas@gmail.com</a><o:p></o:p></p></div></div></div></div></body></html>