<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Using forward-declaration would not fix the layer violation.<div><br><div><div>Le 10 juil. 2014 à 13:10, Bas van den Berg <<a href="mailto:b.van.den.berg.nl@gmail.com">b.van.den.berg.nl@gmail.com</a>> a écrit :</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Well, it does have a Registry& that's defined in Reader.h.<br></div>But that can be forward declared (and apparently is in some<br>of the other headers it includes.<br><br></div><div class="gmail_extra">
<br><br><div class="gmail_quote">On Thu, Jul 10, 2014 at 12:08 PM, Andreas Wendleder <span dir="ltr"><<a href="mailto:andreas.wendleder@googlemail.com" target="_blank">andreas.wendleder@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi<br><div class="gmail_extra"><br><div class="gmail_quote"><div class=""><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">- passes depend on Reader and Writer<br></div></blockquote><div><br></div></div><div>That's an easy one. Compile tested on Windows with Cmake.</div><div><br></div><div>Regards,</div>
<div>
Andreas</div><div><br></div><div>From 36855377f20b0492735339f36ed7c650a4c90624 Mon Sep 17 00:00:00 2001</div><div>From: Andreas Wendleder <<a href="mailto:andreas.wendleder@gmail.com" target="_blank">andreas.wendleder@gmail.com</a>></div>
<div>Date: Thu, 10 Jul 2014 10:58:32 +0100</div><div>Subject: [PATCH] Remove LayoutPass dependency on ReaderWriter.</div><div><br></div><div>It's not used anyway.</div><div>---</div><div> include/lld/Passes/LayoutPass.h | 1 -</div>
<div> 1 file changed, 1 deletion(-)</div><div><br></div><div>diff --git a/include/lld/Passes/LayoutPass.h b/include/lld/Passes/LayoutPass.h</div><div>index 3392480..ffb633d 100644</div><div>--- a/include/lld/Passes/LayoutPass.h</div>
<div>+++ b/include/lld/Passes/LayoutPass.h</div><div>@@ -12,7 +12,6 @@</div><div> </div><div> #include "lld/Core/File.h"</div><div> #include "lld/Core/Pass.h"</div><div>-#include "lld/ReaderWriter/Reader.h"</div>
<div> </div><div> #include "llvm/ADT/DenseMap.h"</div><span class="HOEnZb"><font color="#888888"><div> </div><div>-- </div><div>1.9.2.msysgit.0</div><div><br></div><div> </div></font></span></div><br></div></div>
</blockquote></div><br></div>
_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br></blockquote></div><br></div></body></html>