<div dir="ltr">Hi Tom,<br><br>Looking at your code changes, I don't see any issue, and 198940 should only affect the behavior of c++ program, while MultiSource/Applications/sgefa is a pure c program.<br><br>I tried top of release 3.4.1 with MultiSource/Applications/sgefa, and I can't reproduce the issue. My dump shows with/without the patch you reverted, the test can always pass for AArch64 target.<div>
<br></div><div>So can you tell me on which target it failed? And can you show me the failure log as well?</div><div><br></div><div>Thanks,</div><div>-Jiangning</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
2014-04-22 4:44 GMT+08:00 Tom Stellard <span dir="ltr"><<a href="mailto:tom@stellard.net" target="_blank">tom@stellard.net</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Thu, Apr 17, 2014 at 09:57:32AM -0400, Tom Stellard wrote:<br>
> On Fri, Apr 11, 2014 at 03:02:21PM -0700, Tom Stellard wrote:<br>
> > Hi,<br>
> ><br>
> > I have just tagged the first release candidate for the<br>
> > 3.4.1 release, so testers may begin testing. Please refer to<br>
> > <a href="http://llvm.org/docs/ReleaseProcess.html" target="_blank">http://llvm.org/docs/ReleaseProcess.html</a> for information on how to<br>
> > validate a release. If you have any questions or need<br>
> > something clarified, just email the list.<br>
> ><br>
> > For the 3.4.1 release we want to compare test results against 3.4-final.<br>
> ><br>
> > I have added support to the test-release.sh script for dot releases and<br>
> > have done basic testing. However, if you run into issues please send<br>
> > an email to the list and we can try to get it worked out.<br>
> ><br>
> > When you report your test results to me please remind me of what platform<br>
> > you are testing on.<br>
> ><br>
> > Thanks again to all the testers for your help.<br>
> ><br>
><br>
> Test results are starting to come in, it looks like we have a few<br>
> regressions:<br>
><br>
> x86_64:<br>
> MultiSource/Applications/sgefa<br>
><br>
> ARMV7:<br>
> - new failure: ExecutionEngine/MCJIT/remote/simpletest-remote.ll<br>
> - new unexpected pass:<br>
> ExecutionEngine/MCJIT/remote/cross-module-sm-pic-a.ll<br>
><br>
><br>
> Has anyone attempted to bisect to figure out which commit broke these<br>
> tests?<br>
><br>
<br>
Hi Jiangning,<br>
<br>
This commit that you requested be merged into the 3.4 branch has caused a regression in<br>
the MultiSource/Applications/sgefa test:<br>
<br>
-----------------------------------------------------------------------<br>
<br>
Merging r198940:<br>
<br>
------------------------------------------------------------------------<br>
r198940 | kristof.beyls | 2014-01-10 08:44:34 -0500 (Fri, 10 Jan 2014) | 2 lines<br>
<br>
Enable -fuse-init-array for all AArch64 ELF targets by default, not just linux.<br>
<br>
------------------------------------------------------------------------<br>
-----------------------------------------------------------------------<br>
<br>
I have reverted this in the 3.4 branch, I'm guessing I merged this wrong. Here was<br>
my original attempt: <a href="https://github.com/llvm-mirror/clang/commit/dce55aa1d529e1a07f41241c6a54b9570e0cec64" target="_blank">https://github.com/llvm-mirror/clang/commit/dce55aa1d529e1a07f41241c6a54b9570e0cec64</a><br>
Can you merge r198940 into 3.4 and send me the correct patch.<br>
<br>
Thanks,<br>
Tom<br>
</blockquote></div><br></div>