<div dir="rtl"><div dir="ltr">Hi Chandler,</div><div dir="ltr"><br></div><div dir="ltr">There were five SEH releated patches posted in two threads in the last days.</div><div dir="ltr"><br></div><div dir="ltr">Two different patches in Martell e-mail starting this thread: the win64 seh (llvm) and the register names</div>
<div dir="ltr"><br></div><div dir="ltr">Three more related SEH patches in another thread: one for win64 seh clang, one for MinGW toolchain and another for unreachable prologue. </div><div dir="ltr"><br></div><div dir="ltr">
To clarify and allow proper reviews for the different patches I opened reviews for four of them (the fifth got LGTM in the discussion but it does have the ownership issue you wrote)<br></div><div dir="ltr"><br></div><div dir="ltr">
<span class="" style="font-size:13px;color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3417</span><span style="font-size:13px;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)"> </span><div class="" style="font-size:13px;margin:0px;padding:0px;border:0px;display:inline-block;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">
<a href="http://reviews.llvm.org/D3417" style="color:rgb(24,85,157);text-decoration:none">Emit a trap instruction for IR 'unreachable</a></div><br></div><div dir="ltr"><span class="" style="color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3418</span><span style="color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)"> </span><div class="" style="margin:0px;padding:0px;border:0px;display:inline-block;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">
<a href="http://reviews.llvm.org/D3418" style="text-decoration:none;color:rgb(24,85,157)">SEH exceptions on Win64 (LLVM)</a></div><br></div><div dir="ltr"><span class="" style="color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3419</span><span style="color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)"> </span><div class="" style="margin:0px;padding:0px;border:0px;display:inline-block;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">
<a href="http://reviews.llvm.org/D3419" style="text-decoration:none;color:rgb(24,85,157)">SEH exceptions on Win64 (clang part)</a></div><br></div><div dir="ltr"><span class="" style="color:rgb(75,77,81);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">D3420</span><span style="color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)"> </span><div class="" style="margin:0px;padding:0px;border:0px;display:inline-block;color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;font-weight:bold;line-height:16.003000259399414px;white-space:nowrap;background-color:rgb(240,240,240)">
<a href="http://reviews.llvm.org/D3420" style="text-decoration:none;color:rgb(24,85,157)">MinGW toolchain</a></div><br></div><div dir="ltr"><br></div><div dir="ltr"><div>Per your suggestion the link to the original discussion in D3418 was added.</div>
<div><font face="arial, sans-serif"><br></font></div><div><font face="arial, sans-serif">Code authors are:</font></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">unreachable is by Vadim </span><span style="color:rgb(0,0,0);font-family:'Helvetica Neue',Helvetica,Arial,sans-serif;font-size:13px;line-height:18.850000381469727px">Chugunov.</span></div>
<div dir="ltr">win64 seh llvm is by Kai Nacke + Martell re-posting.</div><div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">win64 seh clang is by Martell.</span><br></div></div><div><div>
<span style="font-family:arial,sans-serif;font-size:12.727272033691406px">mingw toolchain is by Martell.</span><br>
</div></div><div>register names is by <span style="font-size:12.727272033691406px;font-family:arial,sans-serif">Ray Donnelly + Martell posting it.</span><br></div><div>seh test for "register names" <font face="arial, sans-serif">( test is </font>r<span style="font-size:12.727272033691406px;font-family:arial,sans-serif">206566) by myself.</span><br>
</div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"><br></span></div><div><span style="font-family:arial,sans-serif;font-size:12.727272033691406px">All but the "register names" patch</span><span style="font-family:arial,sans-serif;font-size:12.727272033691406px"> were posted by their author on the llvm lists.</span></div>
</div><div dir="ltr"><br></div><div dir="ltr">Yaron</div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"><br></div><div dir="ltr"></div></div>