<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Mar 10, 2014, at 6:23 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 10, 2014 at 6:16 PM, Sean Callanan <span dir="ltr"><<a href="mailto:scallanan@apple.com" target="_blank">scallanan@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Chris,<div><br></div><div>this is a patch against top-of-tree. Maybe I wrote something wrong in the patch?</div>
</div></blockquote></div><br>As Chris said, use_iterator walks over the Use objects now, not over the User objects.</div><div class="gmail_extra"><br></div><div class="gmail_extra">Sadly, a Use *implicitly converts* to the used value. IE, directly back to the Value you called 'use_begin()' on. That is why this assert is firing. =[</div>
<div class="gmail_extra"><br></div><div class="gmail_extra">If you want to walk the Users which Use an object (rather than the Use nodes that connect them) use the newly minted Value::user_iterator (or a range based for loop over GV.users()).</div>
</div>
</blockquote></div><br><div>Chandler, the implicit conversion is an extremely scary thing now in the presence of both use_iterator and user_iterator. Can you remove the implicit conversion? If not, I think we have to get rid of one or the other, or rename them to be less similar.</div><div><br></div><div>-Chris</div></body></html>