<div dir="ltr">virtual bar *foo() = 0;<div><br></div><div>where foo() also exists as pure in the base class. Clang-modernize has a FIXME that says it can't find the "=0" to do the insert of override.</div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Mar 6, 2014 at 3:00 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div class=""><div>On Thu, Mar 6, 2014 at 2:21 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br></div></div><div class="gmail_extra">
<div class="gmail_quote"><div class="">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">It also doesn't do pure methods either.</blockquote><div><br></div></div><div>I think I don't quite understand what that means. Can you give me an example?</div>
<div><div class="h5">
<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><br>On Thursday, March 6, 2014, Rui Ueyama <<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">After running the tool aginst LLD, I realized that clang-modernize do not add "override" to virtual destructors. I think it's not intended but just that that case is not covered by the tool.</div>
<div><br><br><div>On Wed, Mar 5, 2014 at 2:54 PM, Craig Topper <span dir="ltr"><<a>craig.topper@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Didn't realize that. I'll see if i can figure out how to make it delete the virtual keyword.</div>
<div><div><div><br><br><div>On Wed, Mar 5, 2014 at 2:32 PM, Ben Langmuir <span dir="ltr"><<a>blangmuir@apple.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">clang-modernize has a -format option that will run clang-format on the code it changes.<span><font color="#888888"><div>
<br></div></font></span><div><span><font color="#888888">Ben</font></span><div><div><br><div><br></div><div><br><div><div>On Mar 5, 2014, at 2:26 PM, Craig Topper <<a>craig.topper@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">clang-modernize can add the 'override', but it can't currently delete 'virtual'. It will also potentially overflow 80 columns. And if it removed virtual it would fail to align a second line of arguments correctly. So you need modernize and clang-format I guess. Though I'm not sure we want to widespread apply clang-format.</div>
<div><br><br><div>On Wed, Mar 5, 2014 at 1:10 PM, Rui Ueyama <span dir="ltr"><<a>ruiu@google.com</a>></span> wrote:<br><blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr"><div><div><div><div>On Wed, Mar 5, 2014 at 1:02 PM, Marshall Clow <span dir="ltr"><<a>mclow.lists@gmail.com</a>></span> wrote:<br>
<blockquote style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><br><div><div>On Mar 5, 2014, at 10:29 AM, Chris Lattner <<a>clattner@apple.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="word-wrap:break-word"><br><div><div>On Mar 5, 2014, at 9:53 AM, David Blaikie <<a>dblaikie@gmail.com</a>> wrote:</div><br><blockquote type="cite">
<blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
It might be reasonable to warn if a class has both a function marked<br>'override' and a function that overrides but is not marked 'override'.<br><br><br>That could be useful - because it means that the author of the class is at<br>
least thinking about override - but having a "coding style" warning of "I<br>always intend to use override" would still be useful.<br></blockquote><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">Doug (not sure about other Clang owners) is pretty hesitant about</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">implementing coding style warnings - anything with such a high false</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
</blockquote></div></div></blockquote></div></div></div></blockquote></div></div></div></div></div></blockquote></div></div></blockquote></div></div></div></div></div></div></blockquote></div></div></div></div></blockquote>
</div></div></blockquote><br><br></div></div><span><font color="#888888">-- <br>~Craig<br>
</font></span></blockquote></div></div></div><br></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>