<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Feb 12, 2014 at 9:21 PM, Owen Anderson <span dir="ltr"><<a href="mailto:resistor@mac.com" target="_blank">resistor@mac.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div class=""><br><div><div>On Feb 12, 2014, at 7:19 PM, Nico Rieck <<a href="mailto:nico.rieck@gmail.com" target="_blank">nico.rieck@gmail.com</a>> wrote:</div>
<br><blockquote type="cite"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">Oh, and some tests don't even call FileCheck in the first</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
<span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">place!</span></blockquote>
</div><br></div><div>That’s probably because it’s a regression test for a crasher.  It’s checking that the compiler exited successfully.</div></div></blockquote><div><br></div><div>I assume Nico means it's a test with CHECK lines but doesn't invoke FileCheck.<br>
<br>Though personally I object to tests that don't check anything other than "doesn't crash" - if a certain example previously crashed and now doesn't, there was some codepath that was untested (its output unconstrained). The crash just revealed the untested codepath, testing that it doesn't crash still leaves the behavior mostly unconstrained to "do anything other than crashing" which seems insufficient. We should take the opportunity to test the untested behavior that's been discovered.<br>
<br>- David </div></div></div></div>