<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jan 21, 2014, at 5:17 PM, Dan Gohman <<a href="mailto:dan433584@gmail.com">dan433584@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Hi Andy et al,<br><br>Attached is an updated version of the CGContext patch. This fixes some bugs in the previous version, and moves the CGContext registry to TargetMachine. Is this in line with what you expected?<br></div></div></blockquote><div><br></div>Sorry, I put this aside for too long when it wasn’t hard to review at all. This is right in line with what I expected. CGContext is not in the patch, but I get the idea.</div><div><br></div><div>-Andy</div><div><br><blockquote type="cite"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jan 6, 2014 at 11:09 AM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div><div class="h5"><br><div><div>On Jan 6, 2014, at 11:02 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jan 6, 2014 at 1:42 PM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com" target="_blank">atrick@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div>On Jan 6, 2014, at 10:10 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>> wrote:</div>
<br><blockquote type="cite"><div dir="ltr">Trying to bubble way back to the top, Andy, do you think there is anything else that needs to be done here before it can go in? I feel like most of our discussion centered around future work, and I'd like to unblock the immediate work to support subtarget-specific code generation.</div>
</blockquote><div><br></div></div><div>Do we have a solution that can work with TTI? I don’t think there was any objection to putting CGContext in TargetMachine, except that we have too many layers of abstraction, which you said will be cleaned up eventually:</div>
<div><div><br></div><div><font face="Menlo">IR Transform</font></div><div><font face="Menlo">(links with) -> TargetTransformInfo</font></div><div><font face="Menlo">(dynamic call) -> X86TTI</font></div>
<div><font face="Menlo">(links with) -> TargetMachine</font></div><div><font face="Menlo">(provides) -> CGContext</font></div></div></blockquote></div><br>This seems fine to me?</div></div>
</blockquote></div><br></div></div><div>Ok. Future work: do something simpler for TTI, as opposed to analysis groups.</div><div>-Andy</div></div></blockquote></div><br></div>
<span><cgcontext.patch></span></blockquote></div><br></body></html>