<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">thank you.<br>
I'll submit the patch without #ifdef in this case.<br>
Robert<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF192463"><font color="#000000" face="Tahoma" size="2"><b>From:</b> dblaikie@gmail.com [dblaikie@gmail.com]<br>
<b>Sent:</b> 14 January 2014 17:03<br>
<b>To:</b> Robert Lytton; echristo@gmail.com; llvmdev@cs.uiuc.edu<br>
<b>Subject:</b> Re: [LLVMdev] test suite 'owner'<br>
</font><br>
</div>
<div></div>
<div><br>
<br>
<div>On Mon Jan 13 2014 at 12:25:14 PM, Robert Lytton <<a href="mailto:robert@xmos.com" target="_blank">robert@xmos.com</a>> wrote:</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hi Eric,<br>
<br>
Could you explain the intent and policy regarding the test-suite body of code.<br>
Should the test be left as much as possible as-is (even if technically incorrect)?<br>
Should changes only affect the XCore target (#ifdef) or should all targets get the changes?<br>
<br>
Taking "int32_t main" as an example.<br>
The correct return type & argc for main is 'int'.<br>
In the XCore tool chain, 'int32_t' equates to long (IIRC) and hence is not acceptable in the type signature for main.<br>
Should this change be only for the XCore target or all targets?<br>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>All targets. This code is incorrect/non-portable. The return type of main is 'int' per the language spec.</div>
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt"><br>
When I know the policy for the test-suite, I'll alter as necessary & regroup the changes into patches containing the same type of change and submit for approval.<br>
<br>
One more question:<br>
On patch I need to address is how to make deterministic the order of stdout & stderr.<br>
Ideally, applications would use either stdout or stderr but not both.<br>
Would a patch to change to only stdout be acceptable (plus any changes to expected output)?<br>
<br>
Thank you<br>
<br>
Robert<br>
<br>
<br>
<br>
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<hr>
<div style="direction:ltr"><font color="#000000" face="Tahoma"><b>From:</b> Eric Christopher [<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>]<br>
<b>Sent:</b> 13 January 2014 19:16<br>
<b>To:</b> Robert Lytton; <a href="mailto:llvmdev@cs.uiuc.edu" target="_blank">llvmdev@cs.uiuc.edu</a><br>
<b>Subject:</b> [LLVMdev] test suite 'owner'<br>
</font><br>
</div>
</div>
</div>
</div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">
<div style="font-family:Times New Roman; color:#000000; font-size:16px">
<div></div>
<div>Some of these are pretty weird, e.g. int32_t main. Probably the best thing is to submit each patch individually with an explanation of what the purpose is and we can talk about them then.
<div><br>
</div>
<div>-eric</div>
<div>
<div><br>
</div>
</div>
<br>
<div>On Fri Jan 10 2014 at 4:13:47 AM, Robert Lytton <<a href="mailto:robert@xmos.com" target="_blank">robert@xmos.com</a>> wrote:</div>
<blockquote style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt">Hi,<br>
<br>
I have found it necessary to make some changes to the test-suite for the XCore platform.<br>
<br>
These changes include:<br>
altering #includes, as supported by XCore;<br>
using stdout or stderr to make the output diffs consistent (fixing expected output too);<br>
(This work is still under review as best way to do it)<br>
'fixing' symbol and type problems e.g name clashes & scope;<br>
altering/adding code snippets and macros.<br>
<br>
I have used #ifdef to limit and keep any changes specific to the XCore.<br>
Some of these could/should be made common to all targets e.g. log2() -> logTwo().<br>
<br>
I have also altered the Makefile to filter out tests not supported by the XCore.<br>
<br>
I would like to discuss the changes I have found necessary to make and what is the next step.<br>
Should any/all of them be pushed upstream?</div>
</div>
<div>
<div style="direction:ltr; font-family:Tahoma; color:#000000; font-size:10pt"><br>
<br>
Robert<br>
<br>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</div>
</blockquote>
</div>
</div>
</div>
</body>
</html>