<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Kostya,<div><br></div><div>Thanks for the heads-up on this. I haven’t had a chance to look into the details yet, but it looks like these patches may be breaking our bootstrapped LTO build. Our buildbots have been failing all day, and we’re still trying to figure out the problem. I’m going to speculatively revert those changes, since they were the only patches on the buildbot blame list. I will either reapply the changes or help debug the problem.</div><div><br></div><div>—Bob</div><div><br><div><div>On Nov 14, 2013, at 5:42 AM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Bob, Justin,<div><br></div><div>I've just committed a poor man's coverage implementation that works with asan. </div><div><a href="http://llvm.org/viewvc/llvm-project?rev=194701&view=rev">http://llvm.org/viewvc/llvm-project?rev=194701&view=rev</a><br>
</div><div><a href="http://llvm.org/viewvc/llvm-project?rev=194702&view=rev">http://llvm.org/viewvc/llvm-project?rev=194702&view=rev</a><br></div><div>It provides only function-level boolean coverage (i.e. no counters, just "visited or not"),</div>
<div>but is very fast and very simple (no extra sections to the binary file, etc)</div><div>I've tried it for Chrome's content_shell (huge and heavy binary) and the overhead </div><div>is negligible at both run-time and shutdown-time.</div>
<div><br></div><div>We'll be evaluating this implementation and collecting usage stats.</div><div>Maybe we want to implement something simple like this in the Clang coverage.</div><div><br></div><div>--kcc </div></div>
</blockquote></div><br></div></body></html>