<div dir="ltr"><div style="font-family:arial,sans-serif;font-size:13px">Right now, we have:</div><div style="font-family:arial,sans-serif;font-size:13px">In COFF.h:</div><div style="font-family:arial,sans-serif;font-size:13px">

    class COFF { enum MachineTypes { IMAGE_FILE_MACHINE_UNKNOWN   = 0x0, ... }; };</div><div style="font-family:arial,sans-serif;font-size:13px">In windows.h:</div><div style="font-family:arial,sans-serif;font-size:13px">

    #define IMAGE_FILE_MACHINE_UNKNOWN 0<br></div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">* If you first include COFF.h and then windows.h,</div>

<div style="font-family:arial,sans-serif;font-size:13px">    COFF::IMAGE_FILE_MACHINE_UNKNOWN</div><div style="font-family:arial,sans-serif;font-size:13px">will be preprocessed into<br></div><div style="font-family:arial,sans-serif;font-size:13px">

    COFF:0.</div><div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">* If you first include Windows.h and then COFF.h, COFF.h won't work because it's enum will become:</div>

<div style="font-family:arial,sans-serif;font-size:13px">    enum MachinTypes { 0 = 0x0 };</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Aug 29, 2013 at 6:03 AM, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div class="im"><br><div><div>On Aug 27, 2013, at 5:56 PM, Virgile Bello <<a href="mailto:virgile.bello@gmail.com" target="_blank">virgile.bello@gmail.com</a>> wrote:</div>

<br><blockquote type="cite"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;float:none;display:inline!important">Yes of course I understand it was done on purpose.</span><div style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">

It's just that it makes it impossible to include COFF.h and Windows.h side by side (which probably wasn't necessary until now).</div></blockquote><br></div></div><div>I too am in the camp that it is a feature to use the standard names.  For instance doing a search it google or github of the documented names will find uses.</div>

<div><br></div><div>Where exactly is the conflict happening?    Is the problem that something in llvm is including windows.h?  Or that some std lib C/C++ header is being included and the OS provided std header is including windows.h?  </div>

<span class="HOEnZb"><font color="#888888"><div><br></div><div>-Nick</div></font></span></div></blockquote></div><br></div>