<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jul 14, 2013, at 6:38 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Sun, Jul 14, 2013 at 5:57 PM, Andrew Trick <<a href="mailto:atrick@apple.com">atrick@apple.com</a>> wrote:<br><blockquote type="cite"><br>On Jul 12, 2013, at 3:49 PM, Shuxin Yang <<a href="mailto:shuxin.llvm@gmail.com">shuxin.llvm@gmail.com</a>> wrote:<br><br>6) Miscellaneous<br>===========<br> Will partitioning degrade performance in theory. I think it depends on<br>the definition of<br>performance. If performance means execution-time, I guess it dose not.<br>However, if performance includes code-size, I think it may have some<br>negative impact.<br>Following is few scenario:<br><br> - constants generated by the post-IPO passes are not shared across<br>partitions<br> - dead func may be detected during the post-IPO stage, and they may not be<br>deleted.<br><br><br>In don't know if it's feasible, but stable linker output, independent of the<br>partioning, is highly desirable. One of the most irritating performance<br>regressions to track down involves different versions of the host linker. If<br>partitioning decisions are thrown into the mix, this could be annoying. Is<br>it possible for the final link to do a better job cleaning up?<br></blockquote><br>While I haven't yet read the rest of the proposal I'm going to comment<br>on this in particular. In my view this is an absolute requirement as<br>the compiler should produce the same output given the same input every<br>time with no deviation.<br></div></blockquote></div><br><div>The partitioning should be deterministic. It’s just that the linker output now depends on the partitioning heuristics. As long that decision is based on the input (not the host system), then it still meets Eric’s requirements. I just think it’s unfortunate that post-IPO partitioning (or more generally, parallel codegen) affects the output, but may be hard to avoid. It would be nice to be able to tune the partitioning for compile time without worrying about code quality.</div><div><br></div><div>Sorry for the tangential thought here... it seems that most of Shuxin’s proposal is actually independent of LTO, even though the prototype and primary goal is enabling LTO.</div><div><br></div><div>-Andy</div></body></html>