<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On Jun 25, 2013, at 9:15 AM, David Blaikie <<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Tue, Jun 25, 2013 at 8:59 AM, Manman Ren <<a href="mailto:mren@apple.com">mren@apple.com</a>> wrote:<br><blockquote type="cite"><br></blockquote></div></blockquote><canvas width="115" height="91"></canvas><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><blockquote type="cite">Any suggestion on how to move this forward?<br>My feeling is that we should not call Verify from so many files.<br>If you agree, I can try to clean up the Verify functions first.<br></blockquote><br>Yes, we probably shouldn't be using Verify much. I haven't looked at<br>all the use cases though.<br></div></blockquote><div><br></div><div>Verify called from the following 12 files other than DebugInfo DIBuilder Dwarf<br>Index: tools/opt/opt.cpp<br>Index: lib/Target/NVPTX/NVPTXAsmPrinter.cpp<br>Index: lib/Transforms/Utils/Local.cpp<br>Index: lib/Transforms/Instrumentation/GCOVProfiling.cpp<br>Index: lib/Transforms/IPO/StripSymbols.cpp<br>Index: lib/Transforms/IPO/DeadArgumentElimination.cpp<br>Index: lib/CodeGen/SelectionDAG/FastISel.cpp<br>Index: lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp<br>Index: lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp<br>Index: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp<br>Index: lib/CodeGen/MachineInstr.cpp<br>Index: lib/IR/AsmWriter.cpp</div><div><br></div>A sample patch which catches all uses of Verify outside Dwarfxxx.cpp DebugInfo.cpp DIBuilder.cpp:</div><div></div></body></html>