<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">It seems like there is a consensus that this is a good change. Any nay sayers?<div><br></div><div>Michael<br><div><br><div><div>On Jun 18, 2013, at 5:07 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">LGTM (and you've already gotten other positive feedback as well).<br><br>-eric<br><br>On Tue, Jun 18, 2013 at 3:45 PM, Michael Gottesman <<a href="mailto:mgottesman@apple.com">mgottesman@apple.com</a>> wrote:<br><blockquote type="cite">IEEE-754R defines a normal floating point number as:<br><br>2.1.38 normal number: For a particular format, a finite non-zero<br>floating-point number with magnitude greater than or equal to a minimum<br>bemin value, where b is the radix. Normal numbers can use the full precision<br>available in a format. In this standard, zero is neither normal nor<br>subnormal.<br><br>This implies that a denormal is not a normal number.<br><br>In contrast, the current implementation of isNormal in APFloat does treat<br>denormal numbers as normal numbers breaking this definition. This is not<br>just a predicate that has a name that differs from IEEE-754R (which I am<br>fine with), but is an actual name collision with IEEE-754R with a different<br>semantic meaning. This could easily lead to programmer error and thus in my<br>humble opinion is worth the hassle/trouble of fixing.<br><br>Does anyone have any thoughts/suggestions/objections with my renaming<br>isNormal => isFiniteNonZero (and making all the relevant changes in the<br>relevant codebases) and isIEEENormal => isNormal?<br><br>Awaiting the flames,<br>Michael<br><br><br><br>_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a></blockquote></div></blockquote></div><br></div></div></body></html>