<div dir="ltr"><div style>When I build compiler-rt with clang 3.2, all lsan tests pass. The only failing tests I see are in ubsan:</div><div style><br></div><div style><div>Failing Tests (6):</div><div> UndefinedBehaviorSanitizer :: Float/cast-overflow.cpp</div>
<div> UndefinedBehaviorSanitizer :: Integer/add-overflow.cpp</div><div> UndefinedBehaviorSanitizer :: Integer/div-zero.cpp</div><div> UndefinedBehaviorSanitizer :: Integer/sub-overflow.cpp</div><div> UndefinedBehaviorSanitizer :: Integer/uadd-overflow.cpp</div>
<div> UndefinedBehaviorSanitizer :: Integer/usub-overflow.cpp</div><div><br></div><div><br></div><div style>When I build with gcc 4.4.3, I need the changes below to get the source to compile (and then the lsan tests fails). What are you all using to build compiler-rt? are you developing on linux, osx or windows? Using gcc or llvm? Which should I expect to work? Any buildbots running?</div>
</div><div><br></div><div style>And lastly, are there build instructions to build the Android shared object? Is there any way to build an android static lib? How about for arm-linux?</div><div style><br></div><div style>
Thanks,</div><div style>Greg</div><div style><br></div><div><br></div><div>diff --git a/lib/interception/interception.h b/lib/interception/interception.h</div><div>index d50af35..1771d4e 100644</div><div>--- a/lib/interception/interception.h</div>
<div>+++ b/lib/interception/interception.h</div><div>@@ -27,8 +27,8 @@ typedef __sanitizer::uptr SIZE_T;</div><div> typedef __sanitizer::sptr SSIZE_T;</div><div> typedef __sanitizer::sptr PTRDIFF_T;</div><div> typedef __sanitizer::s64 INTMAX_T;</div>
<div>-typedef __sanitizer::OFF_T OFF_T;</div><div>-typedef __sanitizer::OFF64_T OFF64_T;</div><div>+//typedef __sanitizer::OFF_T OFF_T;</div><div>+//typedef __sanitizer::OFF64_T OFF64_T;</div><div> </div><div> // How to add an interceptor:</div>
<div> // Suppose you need to wrap/replace system function (generally, from libc):</div><div>diff --git a/lib/lsan/lsan_allocator.cc b/lib/lsan/lsan_allocator.cc</div><div>index 9bf27b1..190dce8 100644</div><div>--- a/lib/lsan/lsan_allocator.cc</div>
<div>+++ b/lib/lsan/lsan_allocator.cc</div><div>@@ -43,7 +43,7 @@ typedef CombinedAllocator<PrimaryAllocator, AllocatorCache,</div><div> SecondaryAllocator> Allocator;</div><div> </div><div> static Allocator allocator;</div>
<div>-static THREADLOCAL AllocatorCache cache;</div><div>+static /*THREADLOCAL*/ AllocatorCache cache;</div><div> </div><div> void InitializeAllocator() {</div><div> allocator.Init();</div><div>diff --git a/lib/msan/msan_allocator.cc b/lib/msan/msan_allocator.cc</div>
<div>index 7435843..3e6adb6 100644</div><div>--- a/lib/msan/msan_allocator.cc</div><div>+++ b/lib/msan/msan_allocator.cc</div><div>@@ -33,7 +33,7 @@ typedef LargeMmapAllocator<> SecondaryAllocator;</div><div> typedef CombinedAllocator<PrimaryAllocator, AllocatorCache,</div>
<div> SecondaryAllocator> Allocator;</div><div> </div><div>-static THREADLOCAL AllocatorCache cache;</div><div>+static /*THREADLOCAL*/ AllocatorCache cache;</div><div> static Allocator allocator;</div>
<div> </div><div> static int inited = 0;</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, May 24, 2013 at 6:10 AM, Sergey Matveev <span dir="ltr"><<a href="mailto:earthdok@google.com" target="_blank">earthdok@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I blame this line in lsan/lit_tests/lit.cfg:<div><br></div><div><div># Setup attributes common for all compiler-rt projects. </div>
<div>compiler_rt_lit_cfg = os.path.join(llvm_src_root, "projects", "compiler-rt", </div>
<div> "lib", "lit.common.cfg")</div></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, May 24, 2013 at 2:53 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Fri, May 24, 2013 at 3:37 AM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:garious@gmail.com" target="_blank">garious@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div style="font-family:arial,sans-serif;font-size:13px">> it assumes that compiler-rt is checked out to</div>
<div style="font-family:arial,sans-serif;font-size:13px">> llvm/projects/compiler-rt. Apparently, this is a problem.</div>
<div style="font-family:arial,sans-serif;font-size:13px"><br></div></div><div style="font-family:arial,sans-serif;font-size:13px">I have a patch for this ready. I'll send it to you and llvm-commits. Most of the tests pass with "make check-all" but the recently-added lsan tests are all failing. Do those fail for you as well? If so, can we XFAIL them for now and try to keep the "make check-all" build clean?</div>
</div></blockquote><div><br></div><div>Thanks! I'll take a look at the patch today. LSan tests work fine for me, and we have them on our buildbot as well. What are the failures you see?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div style="font-family:arial,sans-serif;font-size:13px"><br></div><div style="font-family:arial,sans-serif;font-size:13px">Thanks,</div><div style="font-family:arial,sans-serif;font-size:13px">Greg</div><div style="font-family:arial,sans-serif;font-size:13px">
<br></div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, May 22, 2013 at 9:39 PM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi!<div><br></div><div>The docs look strange to me - I don't indeed see any CMake support for running compiler-rt tests.</div>
<div>Probably compiler-rt folks can comment on this...</div><div>I think you should run compilert-rt tests manually by smth. like compiler-rt/test/Unit/test.</div>
<div><br></div><div>CMake build system is able of running a bunch of sanitizer tests (AddressSanitizer, ThreadSanitizer etc.), and it assumes that</div><div>compiler-rt is checked out to llvm/projects/compiler-rt. Apparently, this is a problem. There was a patch that tried to address this, but</div>
<div>it never got committed.</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote"><div><div>On Wed, May 22, 2013 at 11:38 PM, Greg Fitzgerald <span dir="ltr"><<a href="mailto:garious@gmail.com" target="_blank">garious@gmail.com</a>></span> wrote:<br>
</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div dir="ltr">Anybody working on porting the compiler-rt tests to cmake?<div><br></div>
<div>The online documentation shows a preference for cmake and ctest, but the CMakeLists file has the comment "Currently the tests have not been ported to CMake, so disable this directory." How should we be running the test suite?</div>
<div><br></div><div><a href="http://compiler-rt.llvm.org/" target="_blank">http://compiler-rt.llvm.org/</a><br></div><div><br></div><div>My immediate issue is that "make check-all" fails in the cmake build when compiler-rt is outside the projects directory. When I point to compiler-rt with LLVM_EXTERNAL_COMPILER_RT_SOURCE_DIR, lit still looks for lit.common.cfg within "projects/compiler-rt" instead of the external directory. I use similar CMake variables for Clang and Polly and have had no trouble. Any recommendations for how to fix?</div>
<div><br></div><div>Thanks,</div><div>Greg</div><div><br></div><div><br></div></div>
<br></div></div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><span><font color="#888888"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</font></span></font></span></div><span><font color="#888888">
</font></span></blockquote></div><span><font color="#888888"><br></font></span></div><span><font color="#888888">
</font></span></div></div></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</font></span></div></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>