<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><br><div><div>On May 8, 2013, at 12:51 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Wed, May 8, 2013 at 11:32 AM, Nadav Rotem <<a href="mailto:nrotem@apple.com">nrotem@apple.com</a>> wrote:<br><blockquote type="cite"><br>On May 8, 2013, at 11:07 AM, <a href="mailto:dag@cray.com">dag@cray.com</a> wrote:<br><br> It might be as simple as adding<br>an IR-level predicated load and predicated store, I'm not sure.<br><br><br>I think that selects on the inputs+outputs of instructions is a good<br>abstraction, and I don't think that we need to add a mask operand to every<br>LLVM IR instruction. However, we do need support for masked load/stores, and<br>I think that we should implement them as target independent intrinsics. I<br>don't want to change the generic LLVM IR Load/Store instructions because I<br>don't want to modify all of the existing optimizations and I also don't want<br>other users of the compiler to pay for this complexity.<br><br></blockquote><br>First statement: I'm not disagreeing. :)<br><br>That said, wouldn't a new intrinsic necessarily require all of the<br>passes to handle it? I'm just curious what you see the tradeoffs being<br>here. I'd have though adding a mask to Load/Store that just isn't<br>handled would be equivalent?<br><br>-eric</div></blockquote></div><div><br></div>Hi Eric, <div><br></div><div>Most passes won't have to handle the load/store intrinsics because they will look like a regular function calls that read/write from memory. We don't need to change Reg2Mem or other passes that really can't do anything about masked memory operations. On the other hand, If we do change the Load/Store instruction we will have to review all of our existing optimizations. For example, some optimizations assume that a store instruction actually writes and invalidates the memory location. However, this assumption is incorrect if we are using a mask. </div><div><div><br></div></div><div>Thanks,</div><div>Nadav</div></body></html>