<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">In theory, the backend should choose the best instructions for the selected target processor. VMLA is not always the best choice. Lang Hames did some measurements a while back to come up with the current behavior, but I don't remember exactly what he found. CC'ing Lang.<div><br><div><div>On Feb 11, 2013, at 8:12 AM, Renato Golin <<a href="mailto:renato.golin@linaro.org">renato.golin@linaro.org</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">On 11 February 2013 15:51, Sebastien DELDON-GNB <span dir="ltr"><<a href="mailto:sebastien.deldon@st.com" target="_blank">sebastien.deldon@st.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><p class=""><span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:11pt">Indeed problem is with generation of vmla.f64. Affected benchmark is MILC from SPEC 2006 suite and disabling vmlx forwarding gives a 10% speed-up on complete benchmark execution ! So it is worth a try.</span></p>
</div></blockquote><div><br></div><div><div>Hi Sebastien,</div><div><br></div><div>Ineed, worth having a look. Including Bob Wilson (who introduced the code in the first place, and is a connoisseur of NEON in LLVM) to see if he has a better idea of the problem.</div>
</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div lang="EN-US" link="blue" vlink="purple"><p class=""><span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:11pt"> Now going back to vmla generation through LLMV intrinsic usage. I’ve looked at .td file and it seems to me that when there is a “pattern” to generate instruction, no intrinsic is defined to generate it, correct ?</span></p>
</div></blockquote><div><br></div><div style="">Correct.</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple"><p class=""><span style="color:rgb(31,73,125);font-family:Calibri,sans-serif;font-size:11pt">Is it possible for an instruction that is generated through a “pattern” to add also an LLVM intrinsic. My goal here is to not rely on LLVM to generate VMLA but rather having my front-end to generate call to a VLMA intrinsic I would have defined when it thinks it’s appropriate to generate one.</span></p>
</div></blockquote><div style="">No, and I'm not sure we should have one.</div><div style=""><br></div><div style="">I understand why you want one, but that's too much back-end knowledge to a front-end, and any pass that can transform a pair of VMLAs into an intrinsic call, can also transform into VMLA+VMUL+VADD. In this case, disabling the optimization is probably the best course of action.</div>
<div style=""><br></div><div style="">In your compiler, you may prefer to leave it always disabled, then you should set it when creating the Target.</div><div style=""><br></div><div style="">If we find that this optimization produces worse code in more cases than not, than we should leave it disable by default and let the user enable when necessary. I'll let Bob follow up on that, since I don't know what benchmarks he used.</div>
<div style=""><br></div><div style="">cheers,</div><div style="">--renato</div></div></div></div>
</blockquote></div><br></div></body></html>