<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">On 12/15/2012 12:53 PM, Chandler
Carruth wrote:<br>
</div>
<blockquote
cite="mid:CAGCO0KgHqHy=CJrSPVRWh86wRqE4sCO0mMWzTv+6ofOWnatz_g@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div style="font-family: arial, helvetica, sans-serif; font-size:
10pt">
<div dir="ltr">On Sat, Dec 15, 2012 at 12:33 PM, Reed Kotler <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:rkotler@mips.com" target="_blank"
class="cremed">rkotler@mips.com</a>></span> wrote:<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">I have
an approved target independent putback and i've run all
that we have at Mips as well as on x86 " make
TEST=simple"<br>
<br>
Is there anything else that is easy to run that I can do
before doing the commit?<br>
<br>
The patch touches a number of basic classes so I'm just
trying to err on the side of caution.<br>
</blockquote>
<div><br>
</div>
<div style="">Your caution is appreciated, but I think
you've done plenty at that point. =] I would commit it,
and if you're worried, get on IRC to watch the various
build bots in case of some failure.</div>
</div>
</div>
</div>
</div>
</blockquote>
I've checked in the code.<br>
<br>
Basically I'm just adding a new method called EmitDebugLabel which
for all ports except for Mips, should be identical to EmitLabel.
Because this is in McElfStreamer, it effects all the classes<br>
derived from that.<br>
<br>
I've tried to be careful and the code was reviewed.<br>
<br>
If for some port I have messed up , it would be better for the
person to just fix the class rather than backing out my whole change
because I have tested it in as many was as are possible for me.<br>
I don't have any way to test this beyond "make check" and test-suite
for x86 and mips and for<br>
those I've already run all the tests and passed.<br>
<br>
Thanks.<br>
<br>
<br>
Reed<br>
</body>
</html>