<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Michael, </div><div><br></div><div>Overall the code looks good.</div><div><br></div>80-cols:<div><br><div><div><font face="Menlo">2046 FMF.UnsafeAlgebra = 0 != (Record[OpNum] & (1 << bitc::FMF_UNSAFE_ALG<b><font color="#e32400">EBRA));</font></b></font></div><div><font face="Menlo">2047 FMF.NoNaNs = 0 != (Record[OpNum] & (1 << bitc::FMF_NO_NANS));</font></div><div><font face="Menlo">2048 FMF.NoInfs = 0 != (Record[OpNum] & (1 << bitc::FMF_NO_INFS));</font></div><div><font face="Menlo">2049 FMF.NoSignedZeros = 0 != (Record[OpNum] & (1 << bitc::FMF_NO_SIGNED_<b><font color="#e32400">ZEROS));</font></b></font></div><div><font face="Menlo">2050 FMF.AllowReciprocal = 0 != (Record[OpNum] & (1 << bitc::FMF_ALLOW_RECI<b><font color="#e32400">PROCAL));</font></b></font></div><div><font face="Menlo"><b><br></b></font></div><div>I found some more in BitcodeReader::ParseConstants(), which I'll scrub after this commits.</div><div><br></div><div>Will there be a // fmul N 1, x ==> x? perhaps a // fadd N S 0, x ==> x? as well as other arithmetic identities?</div><div><br></div><div>Cheers,</div><div><br></div><div>Joe</div>
<br><div><div><br></div><div>On Nov 15, 2012, at 9:54 PM, Michael Ilseman <<a href="mailto:milseman@apple.com">milseman@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Another round of improved patches, and a patch for documentation changes to LangRef.<div> * Make comments more up to date</div><div> * Use 'arcp' instead of 'ar'</div><div> * Use logical ||</div><div><br></div><div>Still based off of r168110</div><div><br></div><div></div></div>
<span><0001-Fast-math-flags-added-to-FPMathOperator.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0002-Fast-math-interfaces-for-Instructions.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0003-Fast-math-flags-for-LLVM-IR-parsing-and-printing.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0004-Fast-math-flags-for-the-bitcode.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0005-Fast-math-test-case-for-bitcode-and-textual-reading-.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0006-Fast-math-optimization-fold-multiply-by-zero.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0007-Fast-math-test-for-SimplifyInstruction-fold-multiply.patch></span><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div></div><div></div></div>
<span><0008-Fast-math-flags-documentation-added-to-LangRef.patch></span></blockquote></div></div></div></body></html>