No problem. Perhaps some of it can be converted into mere patches to existing documentation? <div><br></div><div>That leaves us with three docs so far:</div><div><br></div><div> 1. Testing.</div><div> 2. Windows build.</div>
<div> 3. Windows buildbot slave.</div><div><br><div class="gmail_quote">2012/6/16 Justin Holewinski <span dir="ltr"><<a href="mailto:justin.holewinski@gmail.com" target="_blank">justin.holewinski@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="gmail_quote"><div class="im">On Sat, Jun 16, 2012 at 3:29 AM, Mikael Lyngvig <span dir="ltr"><<a href="mailto:mikael@lyngvig.org" target="_blank">mikael@lyngvig.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Takumi,<div><br></div><div>THANK YOU for your excellent review! It makes all the work worthwhile in itself.</div><div><br></div><div>It is getting "late" here (it is early morning) so I am about to call it a day. But I will contemplate and incorporate your suggestions tomorrow, and send you a full reply. I think I originally wrote a document where I addressed both Visual Studio and MinGW, but then decided that there were way too many "if this" and "if that"s to continue on that path.</div>
<div><br></div><div>Thanks again :-)</div></blockquote><div><br></div></div><div>Under Python installation, you mention that Python is only needed for the test suite. This is not true, as the normal LLVM build still requires Python.</div>
<div><br></div><div>I would seriously consider splitting this up into "building LLVM/Clang" and then "getting and running the test suite." At first glance, a Windows user may get overwhelmed by the number of steps that are listed in this document. But only a handful of them are actually needed if you just want to build LLVM/Clang and do not care about the test suite. Or at the very least include a Windows quick-start guide at the beginning which just lists Python, CMake, and MinGW. And then introduce Subversion if they want the latest sources, then everything else if they want to run the test suite.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5"><div><br></div><div><br></div><div>Cheers,</div><div>Mikael</div><div><div><div><br>
</div><div><br><div class="gmail_quote">2012/6/16 NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com" target="_blank">geek4civic@gmail.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Mikael,<br>
<br>
Thanks for working on.<br>
<br>
My gross comments...<br>
<br>
- Canonical URL of LLVM project is; <a href="http://llvm.org/" target="_blank">http://llvm.org/</a> , not <a href="http://www.llvm.org" target="_blank">www.llvm.org</a>.<br>
<br>
- "test-suite and cygwin" could be split out. It would be special thing.<br>
<br>
- Memory/storage requirements would be moved to "A.B Debugging". Less<br>
memory would be enough without debug build.<br>
<br>
- Python (x64 binary) is available, too. I am using.<br>
Python 2.7.1 (r271:86832, Nov 27 2010, 17:19:03) [MSC v.1500 64 bit<br>
(AMD64)] on win32<br>
<br>
- Distinguish "test-suite" and "{llvm|clang} tests". (Installing GnuWin32)<br>
<br>
- Don't recommend to delete MSYS sh.exe in "Installing CMake". Use<br>
MSYS Makefiles instead with msys.<br>
<br>
- gnuwin32 is not needed on %PATH% if gnuwin32 is dedicated to tests.<br>
Use LLVM_LIT_TOOLS_DIR instead then.<br>
(gnuwin32 is not needed when person is working on MSYS bash shell, FYI)<br>
<br>
- cmake and python are needed on %PATH%, as long as they are not<br>
invoked explicitly.<br>
cmake-generated Makefiles know where they are.<br>
eg. "make edit_cache", "make check"<br>
<br>
- If the target of this would be for newbies, you may mention "cmake-gui", too.<br>
FYI, I am usually use cmake-gui.exe, because I am n00b.<br>
<br>
- (Building the Sources), In my experience, make.exe -jN tends to be<br>
choked. I don't know where is -jN-stable gnu make on mingw. (Lemme<br>
know if you knew better version of make!)<br>
<br>
- Why don't you mention "make {check|clang-test|check-all}", despite<br>
of introducing gnuwin32?<br>
<br>
- You forgot to mention a few important cmake variables.<br>
<br>
- CMAKE_BUILD_TYPE=Release (for most purpose)<br>
- CMAKE_INSTALL_PREFIX (Who would be happy if clang were installed<br>
onto C:\PROGRA~1\?)<br>
- LLVM_LIT_TOOLS_DIR, to use gnuwin32 dedicated to testing llvm and clang.<br>
- LLVM_EXTERNAL_CLANG_SOURCE_DIR, to check out clang outside from<br>
llvm source tree<br>
- PYTHON_EXECUTABLE, if %PATH% does not contain python.<br>
<br>
- Consider to introduce ninja?<br>
<br>
Anyway, this could be integrated to "GettingStartedVS.html" ;)<br>
<span><font color="#888888"><br>
...Takumi<br>
</font></span><br>
ps. feel free to visit and ask me on the irc, oftc#llvm.<br>
</blockquote></div><br></div>
</div></div><br></div></div>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><span class="HOEnZb"><font color="#888888"><br><br clear="all"><div><br></div>-- <br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div><br>
</font></span></blockquote></div><br></div>