<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Done in r156523.<div><br></div><div>Thanks for the patch!</div><div><br></div><div>Regards,</div><div> Jim</div><div><br><div><div>On May 9, 2012, at 4:55 PM, Yury Mikhaylov wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Thank you for your response Jim.<div><br></div><div>As of revision 153342 it applies properly to trunk. No, unfortunately I don't have access, would you please commit it for me?</div><div><br></div><div>Thanks,</div><div>
Yury</div><div><br><div class="gmail_quote">On Wed, May 9, 2012 at 4:37 PM, Jim Grosbach <span dir="ltr"><<a href="mailto:grosbach@apple.com" target="_blank">grosbach@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi Yury,<br>
<br>
No need for the "{" "}" since it's a single statement in the compound statement. Other than that minor style detail, this looks fine assuming it applies cleanly to trunk.<br>
<br>
Do you have commit access?<br>
<br>
Regards,<br>
-Jim<br>
<div><div class="h5"><br>
On May 9, 2012, at 3:40 PM, Yury Mikhaylov wrote:<br>
<br>
> Hi all,<br>
><br>
> Writing my own LLVM client I've noticed a potential null pointer dereference in EngineBuilder::selectTarget.<br>
><br>
> The class has an optional pointer to the ErrorStr, which can be initialzied through setErrorStr() method. Although, it's strictly optional, selectTarget doesn't verify its value before assignment.<br>
><br>
> Please find patch for branch release_31, revision 155051 attached.<br>
><br>
> - Yury<br>
><br>
</div></div>> <TargetSelect.patch>_______________________________________________<br>
> LLVM Developers mailing list<br>
> <a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu/" target="_blank">http://llvm.cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>