<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 11, 2011, at 6:54 PM, John McCall wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">This patch implements the current consensus of PR8973:<div> <a href="http://llvm.org/bugs/show_bug.cgi?id=8973">http://llvm.org/bugs/show_bug.cgi?id=8973</a>.<div><br></div><div>The macro llvm_unreachable is used in LLVM to indicate that</div><div>a particular place in a function is not supposed to be reachable</div><div>during execution. Like an assert macro, it takes a string</div><div>argument. In +Asserts builds, this string argument, together with</div><div>some location information, is passed to a function which prints</div><div>the information and calls abort(). In -Asserts builds, this string</div><div>argument is dropped (to minimize code size impact), and</div><div>instead a bunch of zero arguments are passed to the same</div><div>function.</div></div></span></blockquote></div><br><div>Hi John,</div><div><br></div><div>The patch looks great to me!</div><div><br></div><div>-Chris</div></body></html>