Thanks for taking the time to review this and get it into the mainline.<br><br><div>[snip]</div><div><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div style="word-wrap:break-word"><div>This is because of </div><br><div><div>@@ -1903,7 +1912,8 @@</div><div>     addLabel(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_addr,</div><div>              Asm->GetTempSymbol("section_line"));</div>
<div>   else</div><div>-    addUInt(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_data4, 0);</div><div>+    addSectionOffset(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_addr,</div><div>+             Asm->GetTempSymbol("section_line"));</div>
<div> </div><div>   if (!Dir.empty())</div><div>     addString(Die, dwarf::DW_AT_comp_dir, dwarf::DW_FORM_string, Dir);</div></div><div><br></div><div><br></div><div>You probably wanted  to do...</div><div><br></div><div>
<div>@@ -1904,8 +1913,8 @@</div><div>   // DW_AT_stmt_list is a offset of line number information for this</div><div>   // compile unit in debug_line section.</div><div>   if (Asm->MAI->doesDwarfUsesAbsoluteLabelForStmtList())</div>
<div>-    addLabel(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_addr,</div><div>-             Asm->GetTempSymbol("section_line"));</div><div>+    addSectionOffset(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_addr,</div>
<div>+                     Asm->GetTempSymbol("section_line"));</div><div>   else</div><div>     addUInt(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_data4, 0);</div><div> </div></div></div></blockquote><div><br>
</div><div>I am not sure about this, Looking at it now I don't understand what the return value of doesDwarfUsesAbsoluteLabelForStmtList is supposed to mean. I know that when I allowed the COFF's MCAsmInfo to use this line:</div>
<div><br></div><div>     addUInt(Die, dwarf::DW_AT_stmt_list, dwarf::DW_FORM_data4, 0);</div><div><br></div><div>I got a relocation that caused an absolute pointer to the debug_line section instead of the offset from the beginning of the section. This looked like a bug too me. To me it doesn't matter: I can change DwarfUsesAbsoluteLabelForStmtList to true for MCAsmInfoCOFF and get the correct behavior for COFF output.</div>
<div><br></div><div>[snip]</div><div><br></div><div>-Nathan</div><div><br></div></div></div>