<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks good to me!<div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>- Doug</div><div><br><div><div>On Feb 11, 2011, at 12:55 PM, Zhanyong Wan (λx.x x) wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi Doug,<br><br>While refactoring clang::FileManager to use llvm::sys::path, I had a<br>need for a function to test whether a char is a path separator. I<br>think it would be generally useful. Would you be able to review it?<br>You can see <a href="http://codereview.appspot.com/4186045">http://codereview.appspot.com/4186045</a> or the attachment.<br><br>Thanks,<br>-- <br>Zhanyong<br><span><is_separator.patch></span></div></blockquote></div><br></div></body></html>