<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>Am 22.07.2010 um 00:21 schrieb Chris Lattner:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">On Jul 21, 2010, at 12:49 PM, Eugene Toder wrote:</div> <blockquote type="cite"><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">Is this a recommended approach/good style/good idea to use</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">dyn_cast_or_null<X>(I) instead of dyn_cast_or_null<X>(*I)? (And other</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">is and cast functions).</div> </blockquote><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><br></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">We generally don't want auto-dereference.<span class="Apple-converted-space"> </span>There is some special magic for unwrapping Uses etc though.<span class="Apple-converted-space"> </span>Is this what you're in contact with Gabor?</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><br></div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; ">-Chris</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; min-height: 14px; "><font class="Apple-style-span" color="#006312"><br></font></div> </blockquote><br></div><div>I agree with Chris, that auto-dereferencing is a bad thing (esp. because of the gothcas I detailed).</div><div>I checked in a bunch of fixes to remove auto-dereferencing.</div><div><br></div><div>Maybe we should get rid of the type simplifier for (const_)use_iterator? Sabre what do you think?</div><div><br></div><div>There is one thing that is still irritating me:</div><div>dyn_cast_or_null and cast_or_null have different interfaces. Should these be made consistent?</div><div><br></div><div>Cheers,</div><div><br></div><div><span class="Apple-tab-span" style="white-space:pre"> </span>Gabor</div><br></body></html>