<div class="gmail_quote">On 7 May 2010 08:15, Nathan Jeffords <span dir="ltr"><<a href="mailto:blunted2night@gmail.com">blunted2night@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div></div><div class="h5"><br><br><div class="gmail_quote">On Fri, May 7, 2010 at 12:05 AM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com" target="_blank">clattner@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><br><div><div><div>On May 6, 2010, at 11:22 PM, Nathan Jeffords wrote:</div><br><blockquote type="cite">Thanks! Funny, I was just preparing a patch to submit for my changes to MCSectionCOFF. My changes look to be fairly independent of yours, my change was to deal with COMDAT's. I had dealt with the characteristics flags in the object writer, but I like this. If you don't mind I would like to merge my changes into this patch and submit it. I was just pondering how to deal with the PrintSwitchToSection function without needing the IsDirective flag.<br>
</blockquote><div><br></div></div>I prefer to merge in small independent patches as they are built. Please review Peter's patch (since you know COFF :). I'll take a look tomorrow and apply it if you think it is forward progress, and if there aren't other issues.</div>
<div><br></div><div>Thanks!</div><div><br></div><div>-Chris</div><div><br><blockquote type="cite"><div>
<br><div class="gmail_quote">On Thu, May 6, 2010 at 11:12 PM, Peter S. Housel <span dir="ltr"><<a href="mailto:housel@acm.org" target="_blank">housel@acm.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>On Wed, 2010-05-05 at 13:22 -0700, Nathan Jeffords wrote:<br>
<br>
><br>
> The important point here is that the COFF MCSection needs to<br>
> have the right level of semantic information. In fact,<br>
> MCSection is the place that I'd start for COFF bringup.<br>
><br>
> OK, I see that now. The current isolation<br>
> between TargetLoweringObjectFile -> MCStreamer -> MCObjectWriter has<br>
> proven somewhat problematic, mostly due to my lack of understanding.<br>
> I guess MCSectionXXX was meant to provide communication between them.<br>
> Should the same be true of MCSymbol, and their data counterparts?<br>
<br>
</div>I'm enclosing my patch for reforming MCSectionCOFF to match the<br>
implementation strategy of the other two MCSection classes. You may find<br>
it useful as a starting point. It seems to be complete and correct, and<br>
worked for what I tried with it, but I didn't find time to test it fully<br>
(e.g., by bootstrapping clang under Cygwin).<br>
<br>
Cheers,<br></blockquote></div></div></blockquote></div></div></blockquote></div></div></div></blockquote><div>Looks fine except its 'Emit' not 'Omit'.</div><div><br></div><div>Aaron</div><div><br></div><div>
<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><blockquote type="cite"><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<font color="#888888">-Peter-<br>
<br>
</font></blockquote></div><br></div><div>
_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu" target="_blank">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br></div></blockquote></div><br></div></blockquote></div><br></div></div><div>I have looked over this patch, and do think its forward progress. I was planning additional changes, but I can wait to submit them until this is committed.</div>
<div><br></div>
<br>_______________________________________________<br>
LLVM Developers mailing list<br>
<a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu" target="_blank">http://llvm.cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br>
<br></blockquote></div><br>