<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 7, 2010, at 11:42 AM, Nathan Jeffords wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div class="gmail_quote"><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "><div style="word-wrap: break-word; "><div><div class="h5"><div><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "><div style="word-wrap: break-word; "><div><div>$ llc t.ll -o - -mtriple=i386-apple-darwin10</div><div><span style="white-space: pre; "> </span>.section<span style="white-space: pre; "> </span>__TEXT,__text,regular,pure_instructions</div><div>.zerofill __DATA,__bss,_tst1,4,0 ## @tst1</div><div><span style="white-space: pre; "> </span>.section<span style="white-space: pre; "> </span>__DATA,__data</div><div>_tst2: ## @tst2</div><div><span style="white-space: pre; "> </span>.ascii<span style="white-space: pre; "> </span><span class="Apple-converted-space"> </span>"\000\001\002\003"</div></div></div></blockquote><div><br></div><div>I think we should have an 'EmitZeroFill()' and 'EmitASCII()' OutStream methods, the latter to deal with dllexports in '<span style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; ">lib/Target/X86/AsmPrinter/AsmPrinter.cpp:569'.</span></div><div><span style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; "><br></span></div><div><span style="font-family: arial, sans-serif; font-size: 13px; border-collapse: collapse; ">We also need to sort out COFF TLOF, and get rid of the directive stuff.</span></div></div></blockquote></div><br></div></div><div>It looks to me that you should have an Emit method for the .scl, .def, .type, .endef directives. One callback each.</div><div><br></div><font color="#888888"><div>-Chris</div></font></div></blockquote></div><br><div>I've had included a EmitCOFFSymbolDef in MCStreamer to replace the EmitRawText that was handling this, seem to me it would be easier to have a single call given the restrictions on their use.<br></div></span></blockquote></div><br><div>Sure, whatever you guys think is best. It is also very reasonable to add new enums to MCSymbolAttr if EmitSymbolAttribute is the right callback for these.</div><div><br></div><div>-Chris</div></body></html>