<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi Jeffrey,<br><div><div>On Feb 26, 2010, at 16:02, Jeffrey Yasskin wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">[sidenote: Please try to avoid extraneous whitespace and line wrapping changes in your patches. It makes it harder to see what you're actually changing]<br></blockquote>Sorry just saw some preexisting code was not in 80 columns.<br><blockquote type="cite"><br><div class="gmail_quote">On Fri, Feb 26, 2010 at 4:57 AM, Garrison Venn <span dir="ltr"><<a href="mailto:gvenn.cfe.dev@gmail.com" target="_blank">gvenn.cfe.dev@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap:break-word">Hi Olivier,<div><br><div><div><div>On Feb 25, 2010, at 14:10, Olivier Meurant wrote:</div>
<br><blockquote type="cite">Hi Garrison,<br><br>I finally come back from holidays and take time to watch your patch.<br><br>I must say that I largely prefer this version over the previous one ! I like the reuse of getLazyFunctionStub, but I don't know if the forceEmitFunctionStub is still needed ?<br>
</blockquote><div><br></div></div>JIT::forceEmitFunctionStub(...) was created to bring its implementation into JITEmitter file scope as JITResolver and </div><div>therefore JITResolver::getLazyFunctionStub(...) are members of an anonymous namespace in that scope. However</div>
<div>I can instead use a pre-existing method: getPointerToFunctionOrStub(...) which is declared in ExecutionEngine</div><div>and overwritten in JIT (within JITEmitter file scope). ...</div></div></div></blockquote><div><br>
</div><div>Have you tried the existing pending functions mechanism? I don't want to introduce stubs in eager compilation mode, and I don't think you have to.</div></div>
</blockquote>I'm not sure I understand as forceEmitFunctionStub(...) merely calls getLazyFunctionStub(...) which uses the pending function mechanism. The</div><div>stubs are replaced at compile (JIT) time not at runtime. Is this not how call sites are currently treated? Is this what you are referring to?</div><div><br></div><div>Thanks for looking at this</div><div><br></div><div>Garrison</div><br></body></html>