<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Feb 11, 2010, at 5:15 PM, Talin wrote:</div><blockquote type="cite">OK here's a new patch. Additional comments below.<br><br><div class="gmail_quote">On Wed, Feb 10, 2010 at 10:57 AM, Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com">clattner@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div style="word-wrap:break-word"><div><div>+void ConstantUnion::replaceUsesOfWithOnConstant(Value *From, Value *To,</div></div></div></blockquote><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap:break-word"><div><div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px"><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">+ Use *U) {</div>
<div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">+ assert(false && "Implement replaceUsesOfWithOnConstant for unions");</div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">
+}</div><div style="margin-top:0px;margin-right:0px;margin-bottom:0px;margin-left:0px">+</div><div><br></div><div>Still not implemented?</div></div></div><div><br></div></div></div></blockquote><div>Not in this patch - as you say, it's too large already.</div></div></blockquote><div><br></div>Ok, please work on this as a follow-up patch.</div><div><br><blockquote type="cite"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; "><div style="word-wrap:break-word"><div><div><div><font face="Inconsolata" size="3"><span style="font-size:13px"><br>Otherwise, it looks good, please send these updates and I will commit it for you.</span></font></div><div><font face="Inconsolata" size="3"><span style="font-size:13px"><br>
</span></font></div></div></div></div></blockquote><div>As much as it pains me to say anything that would delay this getting committed, it might make sense to apply this patch after the code freeze - since the feature isn't going to be finished in time for 2.7.</div>
</div></blockquote></div><br><div>I committed the patch in r96011. However, please do follow up with the replaceUsesOfWithOnConstant thing above, and please add a note to the release notes mentioning the feature and saying that it may change in the future.</div><div><br></div><div>Also, please read the llvm developer policy doc and send me the requested info and I'll set you up with commit access, thanks!</div><div><br></div><div>-Chris</div></body></html>