<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 16, 2009, at 1:55 PM, David Greene wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>On Thursday 16 July 2009 14:04, Daniel Dunbar wrote:<br><blockquote type="cite">2009/7/15 Török Edwin <<a href="mailto:edwintorok@gmail.com">edwintorok@gmail.com</a>>:<br></blockquote><blockquote type="cite"><blockquote type="cite">I'm not too keen about seeing buildbots play with trunk ;)<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">How about starting simple, and just auto-tagging builds that work?<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Could be done per OS/arch, and one global tag when all buildbots pass.<br></blockquote></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">I don't know anything about svn performance. Would this negatively<br></blockquote><blockquote type="cite">impact llvm.org, which is already pretty strained?<br></blockquote><br>Tags are cheap.<br><br></div></blockquote><div><br></div><div>Sure, but if you have thousands of them, they become somewhat meaningless. How often are you thinking about tagging? If its every commit, that seems excessive.</div><br><blockquote type="cite"><div><blockquote type="cite">If this is reasonable I think I can update my buildbots to do this<br></blockquote><blockquote type="cite">fairly easily. The global tag is difficult since it requires<br></blockquote><blockquote type="cite">coordination, but individual tags would be easy. It would be nice to<br></blockquote><blockquote type="cite">get the mails from them filtered out, otherwise it will make the<br></blockquote><blockquote type="cite">commit list very noisy.<br></blockquote><br>Thanks to Törok, I think I have the validator buildbot working. The recipe<br>I have does this:<br><br>* Build llvm<br>* Run make check on llvm<br>* Build llvm-gcc, pointed to the just-built llvm<br>* Install llvm-gcc in a temporary locationo<br>* Build llvm again, pointing to the just-installed llvm-gcc<br>* Run make check on llvm<br>* Run llvm-test<br><br>If all of these pass, the validation is considered to succeed.<br><br></div></blockquote><div><br></div><div>How do you determine if llvm-test passes? You need some post processing to compare it to some known valid build (ie. a release). </div><div><br></div><div>-Tanya</div><br><blockquote type="cite"><div>I can easily add make check on llvm-gcc if/when we support it.<br><br>I'd like to take advantage of any tagging infrastructure you add. It would<br>be nice to auto-tag individual validation builds as working. I agree that<br>global tagging can't be automated within the buildbot. Perhaps a daemon<br>could listed to e-mails from the buildbots and tag when a particular<br>revision passes all of the buildbot. That'll come later, though.<br><br>In the meantime, should I attempt to merge my recipe into your buildbot config<br>when you check it into the llvm repository? I'd make separate buildbot <br>factories to run the two recipes (nightly and validation) but the smae slave<br>pool could be used for both. Or should these remain as completely separate<br>buildbots?<br><br>One long-term goal for me is to make validation even more target-sensitive. <br>So for example if we had a way to set default llvm and/or llvm-gcc options<br>to compile for specific implementations (Barcelona vs. Nehalem, for example),<br>we could more rigorously test the optimizer and code generator. I know that<br>for us this would be a big win. But AFAIK there's no way to set default<br>compiler flags like this right now.<br><br> -Dave<br><br>_______________________________________________<br>LLVM Developers mailing list<br><a href="mailto:LLVMdev@cs.uiuc.edu">LLVMdev@cs.uiuc.edu</a> <a href="http://llvm.cs.uiuc.edu">http://llvm.cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev">http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev</a><br></div></blockquote></div><br></body></html>